Log execution API server URL at task startup #57343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
reviewed
Oct 27, 2025
jscheffl
approved these changes
Oct 27, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Good for me. The title anticipated "Move" but I see "Add - is the log to be deleted on some other place?
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
jscheffl
force-pushed
the
move-log-to-supervise
branch
from
7a48d04 to
edd63b6
Compare
Contributor
Author
Nope, no deletions anywhere. I could delete in "execute_workload.py" to avoid duplicates, will send a PR to do that |
amoghrajesh
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
(cherry picked from commit cd32d1b) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Backport successfully created: v3-1-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 28, 2025
(cherry picked from commit cd32d1b) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
jason810496
pushed a commit
that referenced
this pull request
Oct 28, 2025
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There could be cases when custom executors (edge for example faced it), where we do not log where the worker is trying to connect during task startup time.
Edge: https://github.com/apache/airflow/blob/main/providers/edge3/src/airflow/providers/edge3/cli/worker.py#L188-L204
VS celery / KE: https://github.com/apache/airflow/blob/main/task-sdk/src/airflow/sdk/execution_time/execute_workload.py#L58-L64
I figured it is better to have double logs for debugging than none. I could remove it for celery / KE and rest if needed, but this one is more important.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.