Skip to content

Conversation

@jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Oct 27, 2025

Authentication token handling changed in UI in Airflow core 3.1.1, this PR adjusts the UI Plugin for Edge Provider in order to follow.

If not using this version it might lead in Airflow UI 3.1.1 to API authentication errors and then the "token" must be manually deleted from local storage. After this PR there is no more axois auth glitch

Note that this is finally a breaking change making the UI Plugin un-usable with Airflow 3.1.0, for this the Edge provider 1.4.0 is the last compatible version. All other versions are "fine". This is following the experimental React plugin interface. Some more breaking changes to be expected in next minors.

FYI @dheerajturaga

@boring-cyborg boring-cyborg bot added area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3 labels Oct 27, 2025
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you set a constraint on Airflow >= 3.1.1 or you intend to doit in a follow-up PR?

@jscheffl
Copy link
Contributor Author

Should you set a constraint on Airflow >= 3.1.1 or you intend to doit in a follow-up PR?

Constraint is already on main in https://github.com/boschglobal/airflow/blob/main/providers/edge3/pyproject.toml#L60 - so no additional imitation needed here.
Note: I actually thought earlier that the change of the dom-router was a breaking change but needed to realize that the token was breaking "harder".

@vincbeck
Copy link
Contributor

Should you set a constraint on Airflow >= 3.1.1 or you intend to doit in a follow-up PR?

Constraint is already on main in https://github.com/boschglobal/airflow/blob/main/providers/edge3/pyproject.toml#L60 - so no additional imitation needed here. Note: I actually thought earlier that the change of the dom-router was a breaking change but needed to realize that the token was breaking "harder".

I think it should be set to >= 3.1.1, I do not think this would work, for example, with 3.0.0

@jscheffl
Copy link
Contributor Author

jscheffl commented Oct 27, 2025

Should you set a constraint on Airflow >= 3.1.1 or you intend to doit in a follow-up PR?

Constraint is already on main in https://github.com/boschglobal/airflow/blob/main/providers/edge3/pyproject.toml#L60 - so no additional imitation needed here. Note: I actually thought earlier that the change of the dom-router was a breaking change but needed to realize that the token was breaking "harder".

I think it should be set to >= 3.1.1, I do not think this would work, for example, with 3.0.0

Oh okay. yeah actually it is:

  • It is working with Airflow 2.10+2.11 as there is a "legacy UI" plugin used.
  • It is not a problem in 3.0.x as this Airflow version is lagging any Plugin function.
  • The breaking change is only between 3.1.0 and 3.1.1++

The general Edge Worker/Executor is not affected from the breaking change, only the UI plugin has a problem with exactly and only 3.1.0.
And this is only acceptable as the UI plugin functionality is marked experimental in 3.1.0 that allows us to fix problems in React integration (which sadly we need to :-( )

@vincbeck
Copy link
Contributor

Should you set a constraint on Airflow >= 3.1.1 or you intend to doit in a follow-up PR?

Constraint is already on main in https://github.com/boschglobal/airflow/blob/main/providers/edge3/pyproject.toml#L60 - so no additional imitation needed here. Note: I actually thought earlier that the change of the dom-router was a breaking change but needed to realize that the token was breaking "harder".

I think it should be set to >= 3.1.1, I do not think this would work, for example, with 3.0.0

Oh okay. yeah actually it is:

  • It is working with Airflow 2.10+2.11 as there is a "legacy UI" plugin used.
  • It is not a problem in 3.0.x as this Airflow version is lagging any Plugin function.
  • The breaking change is only between 3.1.0 and 3.1.1++

The general Edge Worker/Executor is not affected from the breaking change, only the UI plugin has a problem with exactly and only 3.1.0. And this is only acceptable as the UI plugin functionality is marked experimental in 3.1.0 that allows us to fix problems in React integration (which sadly we need to :-( )

Ohhh you're right! My god, this is a puzzle between all the versions haha. But it is fine by me then :)

@jscheffl
Copy link
Contributor Author

Should you set a constraint on Airflow >= 3.1.1 or you intend to doit in a follow-up PR?

Constraint is already on main in https://github.com/boschglobal/airflow/blob/main/providers/edge3/pyproject.toml#L60 - so no additional imitation needed here. Note: I actually thought earlier that the change of the dom-router was a breaking change but needed to realize that the token was breaking "harder".

I think it should be set to >= 3.1.1, I do not think this would work, for example, with 3.0.0

Oh okay. yeah actually it is:

  • It is working with Airflow 2.10+2.11 as there is a "legacy UI" plugin used.
  • It is not a problem in 3.0.x as this Airflow version is lagging any Plugin function.
  • The breaking change is only between 3.1.0 and 3.1.1++

The general Edge Worker/Executor is not affected from the breaking change, only the UI plugin has a problem with exactly and only 3.1.0. And this is only acceptable as the UI plugin functionality is marked experimental in 3.1.0 that allows us to fix problems in React integration (which sadly we need to :-( )

Ohhh you're right! My god, this is a puzzle between all the versions haha. But it is fine by me then :)

I hope all this hairball is resolved soon so that I can drain this complexity from my brain.

@jscheffl jscheffl merged commit ce990bb into apache:main Oct 27, 2025
64 checks passed
@dheerajturaga
Copy link
Member

@jscheffl Thanks for the fix! I dont see those errors now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants