-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Adjust authentication token after UI changes in 3.1.1 #57370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust authentication token after UI changes in 3.1.1 #57370
Conversation
vincbeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you set a constraint on Airflow >= 3.1.1 or you intend to doit in a follow-up PR?
Constraint is already on main in https://github.com/boschglobal/airflow/blob/main/providers/edge3/pyproject.toml#L60 - so no additional imitation needed here. |
I think it should be set to >= 3.1.1, I do not think this would work, for example, with 3.0.0 |
Oh okay. yeah actually it is:
The general Edge Worker/Executor is not affected from the breaking change, only the UI plugin has a problem with exactly and only 3.1.0. |
Ohhh you're right! My god, this is a puzzle between all the versions haha. But it is fine by me then :) |
I hope all this hairball is resolved soon so that I can drain this complexity from my brain. |
|
@jscheffl Thanks for the fix! I dont see those errors now :) |
Authentication token handling changed in UI in Airflow core 3.1.1, this PR adjusts the UI Plugin for Edge Provider in order to follow.
If not using this version it might lead in Airflow UI 3.1.1 to API authentication errors and then the "token" must be manually deleted from local storage. After this PR there is no more axois auth glitch
Note that this is finally a breaking change making the UI Plugin un-usable with Airflow 3.1.0, for this the Edge provider 1.4.0 is the last compatible version. All other versions are "fine". This is following the experimental React plugin interface. Some more breaking changes to be expected in next minors.
FYI @dheerajturaga