Bugfix/support Subpath w/o Execution API Url #57372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
kind:documentation
provider:edge
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vincbeck
reviewed
Oct 27, 2025
Contributor
vincbeck
left a comment
vincbeck
left a comment
There was a problem hiding this comment.
Any way to cover this use case with a test?
Contributor
Author
At least I need to adjust existing tests to make CI Green, will push/fix some in a moment :-D |
2 tasks
amoghrajesh
approved these changes
Oct 28, 2025
eladkal
reviewed
Oct 28, 2025
amoghrajesh
reviewed
Oct 28, 2025
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Member
|
Looks good! thanks for this! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the execution URL needs to be added explicitly when deploying to a sub-path. This is a "burden" for Edge because other workers which are running inK8s (e.g. Celery) still benefit from an internal API endpoint.
If not provided the grepping of the execution API URL is now following the edge API URL per default and includes support of sub-path. Also the URL is logged (once) which makes error triaging easier.
FYI @dheerajturaga