Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Oct 27, 2025

Seems that old version of fast-api does not have typer as dependency and when we go to "lowest dependencies" typer is removed even if fast-api tests need it.

This PR adds typer-slim (which is trimmed-down version of typer that does not bring a typer cli) as common development dependency.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Seems that old version of fast-api does not have typer as dependency
and when we go to "lowest dependencies" typer is removed even if
fast-api tests need it.

This PR adds typer-slim (which is trimmed-down version of typer
that does not bring a typer cli) as common development dependency.
@potiuk potiuk added the full tests needed We need to run full set of tests for this PR to merge label Oct 27, 2025
@potiuk potiuk closed this Oct 27, 2025
@potiuk potiuk reopened this Oct 27, 2025
@potiuk
Copy link
Member Author

potiuk commented Oct 27, 2025

Added full tests

@potiuk potiuk added the canary When set on PR running from apache repo - behave as canary run label Oct 27, 2025
@potiuk potiuk closed this Oct 27, 2025
@potiuk potiuk reopened this Oct 27, 2025
@potiuk
Copy link
Member Author

potiuk commented Oct 27, 2025

And canary

@potiuk
Copy link
Member Author

potiuk commented Oct 27, 2025

Fix to broken main (lower deps)

@potiuk potiuk added this to the Airflow 3.1.2 milestone Oct 27, 2025
@potiuk potiuk added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Oct 27, 2025
@potiuk potiuk merged commit 0055283 into apache:main Oct 27, 2025
170 of 197 checks passed
@potiuk potiuk deleted the add-typer-as-development-dependency branch October 27, 2025 22:59
github-actions bot pushed a commit that referenced this pull request Oct 27, 2025
Seems that old version of fast-api does not have typer as dependency
and when we go to "lowest dependencies" typer is removed even if
fast-api tests need it.

This PR adds typer-slim (which is trimmed-down version of typer
that does not bring a typer cli) as common development dependency.
(cherry picked from commit 0055283)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@github-actions
Copy link

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

potiuk added a commit that referenced this pull request Oct 27, 2025
#57387)

Seems that old version of fast-api does not have typer as dependency
and when we go to "lowest dependencies" typer is removed even if
fast-api tests need it.

This PR adds typer-slim (which is trimmed-down version of typer
that does not bring a typer cli) as common development dependency.
(cherry picked from commit 0055283)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch canary When set on PR running from apache repo - behave as canary run full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants