Skip to content

Conversation

@github-actions
Copy link

  • Fix text selection jumping in logs pane to match text editor behavior

    When selecting text by clicking and dragging in the logs pane, the
    selection would jump unexpectedly when clicking in empty space at
    the end of lines or below the last log line. This was caused by the
    virtualized list rendering with absolutely positioned elements that
    didn't extend to fill available space.

    Changes:

    • Make log line containers full width to enable selection in empty areas
    • Add invisible filler element below last log line to prevent EOF jump
    • Ensure minimum height covers all empty space at bottom of container

    The logs pane now behaves like traditional text editors (e.g. Notepad)
    where users can click anywhere and drag to select multiple lines without
    the selection jumping.

  • Fix log view vanishing when text wrap is enabled

    When toggling text wrap on in the logs pane, all log content would
    disappear. This was caused by three issues:

    1. CSS textWrap property was set to pre instead of pre-wrap, which
      preserves whitespace but does not wrap text
    2. Virtualizer was not remeasuring items when wrap toggled, causing
      items to be positioned with cached single-line heights even when
      text became multi-line
    3. Width constraints conflicted - items need to be constrained to 100%
      when wrapped (to force wrapping) but max-content when unwrapped
      (to allow horizontal scrolling)

    Changes:

    • Change textWrap from pre to pre-wrap when wrap is enabled
    • Add useLayoutEffect to force virtualizer remeasurement on wrap toggle
    • Add width=100% to VStack to provide proper width reference
    • Set item width conditionally: 100% when wrapped, max-content when not
    • Keep minWidth=100% always for text selection in empty areas
      (cherry picked from commit d6fa3b0)

Co-authored-by: Dheeraj Turaga dheerajturaga@gmail.com

…tor behavior (#57309)

* Fix text selection jumping in logs pane to match text editor behavior

  When selecting text by clicking and dragging in the logs pane, the
  selection would jump unexpectedly when clicking in empty space at
  the end of lines or below the last log line. This was caused by the
  virtualized list rendering with absolutely positioned elements that
  didn't extend to fill available space.

  Changes:
  - Make log line containers full width to enable selection in empty areas
  - Add invisible filler element below last log line to prevent EOF jump
  - Ensure minimum height covers all empty space at bottom of container

  The logs pane now behaves like traditional text editors (e.g. Notepad)
  where users can click anywhere and drag to select multiple lines without
  the selection jumping.

* Fix log view vanishing when text wrap is enabled

  When toggling text wrap on in the logs pane, all log content would
  disappear. This was caused by three issues:

  1. CSS textWrap property was set to pre instead of pre-wrap, which
     preserves whitespace but does not wrap text
  2. Virtualizer was not remeasuring items when wrap toggled, causing
     items to be positioned with cached single-line heights even when
     text became multi-line
  3. Width constraints conflicted - items need to be constrained to 100%
     when wrapped (to force wrapping) but max-content when unwrapped
     (to allow horizontal scrolling)

  Changes:
  - Change textWrap from pre to pre-wrap when wrap is enabled
  - Add useLayoutEffect to force virtualizer remeasurement on wrap toggle
  - Add width=100% to VStack to provide proper width reference
  - Set item width conditionally: 100% when wrapped, max-content when not
  - Keep minWidth=100% always for text selection in empty areas
(cherry picked from commit d6fa3b0)

Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 28, 2025
@jscheffl jscheffl marked this pull request as ready for review October 28, 2025 21:23
@jscheffl jscheffl merged commit e4d4514 into v3-1-test Oct 28, 2025
53 checks passed
@jscheffl jscheffl deleted the backport-d6fa3b0-v3-1-test branch October 28, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants