-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Enable ruff PLW0120 rule #57456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ruff PLW0120 rule #57456
Conversation
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
753a6a1 to
3a7a807
Compare
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 944a9f5 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
(cherry picked from commit 944a9f5) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
(cherry picked from commit 944a9f5) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
While implementing #57294 I realized that a couple of more ruff PLW rules might be interesting, this PR enabled PLW0127
See also https://docs.astral.sh/ruff/rules/#warning-plw