Skip to content

Conversation

@jscheffl
Copy link
Contributor

While implementing #57294 I realized that a couple of more ruff PLW rules might be interesting, this PR enabled PLW0127

See also https://docs.astral.sh/ruff/rules/#warning-plw

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@jscheffl jscheffl force-pushed the feature/add-ruff-plw0120-rule branch from 753a6a1 to 3a7a807 Compare October 29, 2025 18:30
@jscheffl jscheffl merged commit 944a9f5 into apache:main Oct 29, 2025
518 of 582 checks passed
@github-actions
Copy link

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 944a9f5 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

jscheffl added a commit to jscheffl/airflow that referenced this pull request Oct 29, 2025
(cherry picked from commit 944a9f5)

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Lzzz666 pushed a commit to Lzzz666/airflow that referenced this pull request Oct 30, 2025
jscheffl added a commit to jscheffl/airflow that referenced this pull request Oct 30, 2025
(cherry picked from commit 944a9f5)

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
jason810496 pushed a commit that referenced this pull request Oct 31, 2025
* [v3-1-test] Enable ruff PLW0120 rule (#57456)
(cherry picked from commit 944a9f5)

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

* fix static checks
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CLI area:dev-tools area:logging area:providers backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch provider:amazon AWS/Amazon - related issues provider:elasticsearch provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants