-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix HITL operators failing when using notifiers #57494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
reviewed
Oct 29, 2025
2adab6f to
43f44c4
Compare
43f44c4 to
886f1c1
Compare
ashb
reviewed
Oct 29, 2025
Lee-W
approved these changes
Oct 30, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 30, 2025
(cherry picked from commit 552e605) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 30, 2025
amoghrajesh
added a commit
that referenced
this pull request
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:task-sdk
backport-to-v3-1-test
Mark PR with this label to backport to v3-1-test branch
type:bug-fix
Changelog: Bug Fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #57437
Problem and Root cause
The root cause for this failure and resulting error like this:
was a type mismatch between API response and client expectations in SDK.
The client's
add_response()method tried to parse API JSON directly asHITLDetailRequestResult:But the API returns JSON without a
typefield:{ "ti_id": "...", "options": [...], "subject": "...", // NO "type" field }HITLDetailRequestResultis part of a discriminated union (ToTask) that requires atypediscriminator field for Pydantic to deserialize correctly. Since the API doesn't include this field, validation failed.This issue can be fixed by correcting the types sent across between client <=> supervisor. Client returns
HITLDetailRequest, supervisor converts toHITLDetailRequestResult(similar pattern to XCom req/resp) by using afrom_api_responsedefined onHITLDetailRequestResultTesting
Used this DAG:
Created an SMTP connection with host as:
mailpit, port as1025Flow:
Notifier sent this email:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.