Skip to content

Add number of queries guard in public dag stats list endpoints #57496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 1 commit into from
Oct 31, 2025
Merged

Add number of queries guard in public dag stats list endpoints #57496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from airflow.utils.state import DagRunState
from airflow.utils.types import DagRunType

from tests_common.test_utils.asserts import assert_queries_count
from tests_common.test_utils.db import (
clear_db_dag_bundles,
clear_db_dags,
Expand Down Expand Up @@ -193,7 +194,8 @@ def test_should_respond_200(self, test_client, session, testing_dag_bundle):
"total_entries": 2,
}

response = test_client.get(f"{API_PREFIX}?dag_ids={DAG1_ID}&dag_ids={DAG2_ID}")
with assert_queries_count(2):
response = test_client.get(f"{API_PREFIX}?dag_ids={DAG1_ID}&dag_ids={DAG2_ID}")
assert response.status_code == 200
res_json = response.json()
assert res_json["total_entries"] == len(res_json["dags"])
Expand Down Expand Up @@ -281,7 +283,8 @@ def test_all_dags_should_respond_200(self, test_client, session, testing_dag_bun
"total_entries": 3,
}

response = test_client.get(API_PREFIX)
with assert_queries_count(2):
response = test_client.get(API_PREFIX)
assert response.status_code == 200
res_json = response.json()
assert res_json["total_entries"] == len(res_json["dags"])
Expand Down Expand Up @@ -435,7 +438,9 @@ def test_all_dags_should_respond_200(self, test_client, session, testing_dag_bun
)
def test_single_dag_in_dag_ids(self, test_client, session, testing_dag_bundle, url, params, exp_payload):
self._create_dag_and_runs(session)
response = test_client.get(url, params=params)

with assert_queries_count(2):
response = test_client.get(url, params=params)
assert response.status_code == 200
res_json = response.json()
assert res_json["total_entries"] == len(res_json["dags"])
Expand Down
Loading