Add number of queries guard in public dags list endpoints #57506
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
added
the
backport-to-v3-1-test
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds database query count assertions to the test_get_dags parameterized test to ensure performance regression prevention by verifying that the endpoint consistently executes exactly 4 database queries.
- Added
assert_queries_countimport from test utilities - Wrapped the API call in
test_get_dagswith a query count assertion expecting 4 queries
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kaxil
approved these changes
Oct 29, 2025
pierrejeambrun
force-pushed
the
add-query-guard-for-public-dags
branch
from
c23d5b7 to
70f277c
Compare
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker dc73d38 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
pierrejeambrun
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 30, 2025
(cherry picked from commit dc73d38)
Member
Author
|
Manual backport #57556 |
pierrejeambrun
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 31, 2025
(cherry picked from commit dc73d38)
pierrejeambrun
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 31, 2025
(cherry picked from commit dc73d38)
pierrejeambrun
added a commit
that referenced
this pull request
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add number of db queries guard in list endpoint, preventing further N+1 queries problem
No N+1 queries problem detected.