Skip to content

Conversation

@ryanahamilton
Copy link
Contributor

Follow-up to #57455

When attempting to back-port #57455 into v3-1-test, merging was blocked by linting errors that were not shown by my IDE when authoring, nor did they become blocking when attempting to commit the code.

@bbovenzi is going to investigate why I was able to commit the invalid code, and in this PR, I am fixing the previously uncaught issues.

I added .vscode/ config files that ensure auto-formatting occurs on-save for UI files. After I configured this, it resolved most of the issues automatically. These setting work for VS Code or any fork of it (like Cursor).

Most of the issues were related to prop ordering and indentations, but it did catch an issue in how the Plugin nav item icons are being rendered and I've fixed that as well.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 29, 2025
@bbovenzi bbovenzi added this to the Airflow 3.1.2 milestone Oct 30, 2025
@bbovenzi bbovenzi added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Oct 30, 2025
@bbovenzi bbovenzi merged commit 968b637 into apache:main Oct 30, 2025
57 checks passed
@bbovenzi bbovenzi deleted the nav_linting branch October 30, 2025 14:02
@github-actions
Copy link

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 968b637 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@rawwar
Copy link
Contributor

rawwar commented Oct 30, 2025

I don't think we should have .vscode in the repo. I have my own vscode config and now, it always shows up as a change.

If required, we can update setup_vscode.py to automatically generate such config. we already use that to generate debug config

@ryanahamilton
Copy link
Contributor Author

I don't think we should have .vscode in the repo. I have my own vscode config and now, it always shows up as a change.

If required, we can update setup_vscode.py to automatically generate such config. we already use that to generate debug config

In other projects I've worked on we check these files in as the "Workspace" configuration as they are considered to have a collective agreement around them. In the case of the settings I added, those enforce the required linting of the project and should not be optional.

kaxil added a commit that referenced this pull request Oct 31, 2025
…l navigation (#57455)(#57565)

* Refine the visual design, interaction, and accessibility of the global navigation (#57455)

* Add settings to auto-apply linting, fix linting errors (#57510)

* Fix static checks

---------

Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
kaxil added a commit that referenced this pull request Oct 31, 2025
…l navigation (#57455)(#57565)

* Refine the visual design, interaction, and accessibility of the global navigation (#57455)

* Add settings to auto-apply linting, fix linting errors (#57510)

* Fix static checks

---------

Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants