Skip to content

Conversation

@dabla
Copy link
Contributor

@dabla dabla commented Oct 30, 2025

Added paginated_run method in KiotaRequestAdapterHook so that pagination is not only possible through the MSGraphAsyncOperator but also through the hook, so we can easily do paginated calls from python decorated tasks.

Also allow overriding proxy settings on the hook with empty dict when proxy is already defined in connection.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@dabla dabla marked this pull request as draft October 30, 2025 18:44
@dabla dabla marked this pull request as ready for review November 26, 2025 06:55
@potiuk potiuk merged commit 4ea1ebf into apache:main Dec 8, 2025
85 checks passed
@dabla
Copy link
Contributor Author

dabla commented Dec 9, 2025

Thx @potiuk

henry3260 pushed a commit to henry3260/airflow that referenced this pull request Dec 10, 2025
…che#57536)

* refactor: Added paginated_run method to KiotaRequestAdapterHook

* refactor: Make execution of pagination function dynamic in KiotaRequestAdapterHook

* refactor: Refactored PaginationCallable as protocol in KiotaRequestAdapterHook

* Revert "refactor: Refactored PaginationCallable as protocol in KiotaRequestAdapterHook"

This reverts commit 1885132.

* refactor: Ignore type with execute_callable

* refactor: Fixed default_pagination in MSGraphAsyncOperator

* fix: url of default_pagination should be optional

* fix: Fixed unit test related to pagination with operator

* Revert "fix: Fixed unit test related to pagination with operator"

This reverts commit 2ff2fa1.

* refactor: Replace default_pagination back to static paginate method in MSGraphAsyncOperator

* refactor: Allow overriding proxy settings in MSGraph hook with empty dict so that proxy settings from connection are ignored

* refactor: Reformatted tests

* refactor: Make sure host starts with http or https

* refactor: Fixed typing

* refactor: Fixed proxy tests

* refactor: Accept warnings raised by get_conn method

* refactor: Reformatted proxies tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants