Skip to content

Comments

Eliminate serdag loading added in #56422#57537

Merged
kaxil merged 1 commit intoapache:mainfrom
astronomer:eliminate-multiquery
Oct 30, 2025
Merged

Eliminate serdag loading added in #56422#57537
kaxil merged 1 commit intoapache:mainfrom
astronomer:eliminate-multiquery

Conversation

@ephraimbuddy
Copy link
Contributor

It was wrong to load the serdag and not use it. The initial idea was to use the serdag at line 437 but was omitted. Thinking about it now, it will be faster to only load serdag when there's a TI associated with the dag version

It was wrong to load the serdag and not use it. The initial idea was
to use the serdag at line 437 but was omitted. Thinking about it now,
it will be faster to only load serdag when there's a TI associated
with the dag version
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now, but this logic around updating ser dag needs to change.

Let me create a PR later in the day

@kaxil kaxil merged commit e5a88cc into apache:main Oct 30, 2025
63 checks passed
@kaxil kaxil deleted the eliminate-multiquery branch October 30, 2025 13:18
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
It was wrong to load the serdag and not use it. The initial idea was
to use the serdag at line 437 but was omitted. Thinking about it now,
it will be faster to only load serdag when there's a TI associated
with the dag version
@ephraimbuddy ephraimbuddy added this to the Airflow 3.1.7 milestone Jan 22, 2026
ephraimbuddy added a commit that referenced this pull request Jan 27, 2026
It was wrong to load the serdag and not use it. The initial idea was
to use the serdag at line 437 but was omitted. Thinking about it now,
it will be faster to only load serdag when there's a TI associated
with the dag version

(cherry picked from commit e5a88cc)
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:serialization changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants