Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
potiuk
left a comment
There was a problem hiding this comment.
We are currently on pause with adding new providers.
And in any case In order to add a new provider, one has to start discussion on devlist. We have a discussion opened on whether we want to add new providers and what expectations would be for those who submit the providers
https://lists.apache.org/thread/qrv0j4dxp2yg09gds40vh49dhkbrj5q9
If you would like to advance the discussion @cetingokhan you should comment the proposal we have there.
It explains things that you (the person who submits the provider) will have to commit to (maintenance) and what conditions will have to be met in order to move from default "incubation" state to graduate to "official".
Please add your comments to the discussion if you would like to advance the discussion - no providers will be accepted until the discussion concludes I guess.
This comment was marked as outdated.
This comment was marked as outdated.
|
Hey @cetingokhan, Following up on Jarek's earlier comment -- the AIP-95 Provider Governance vote has concluded and passed (result). This establishes a new process for adding providers to Airflow. Governance requirements: Before we can consider any new provider, contributors need to:
This applies to all new provider PRs -- we won't be merging any until the proposal goes through the mailing list. Also, this PR also has unrelated changes that need to be removed:
These look like local checkout issues that got committed accidentally. Once you've gone through the governance process on the mailing list, you can rebase and clean up this PR. Let us know if you have any questions or need clarifications. |
|
Hello @kaxil, Thank you for your guidance and for highlighting the new management requirements. I have reviewed the AIP-95 proposal. As you mentioned, I need a Committer sponsor to start the discussion on the email list. Are you open to sponsoring this provider, or can you suggest someone who might be interested? I can assure you I will handle the heavy lifting related to maintaining the provider. Regarding the irrelevant changes (deleted symbolic links): As you guessed, this was an unintended side effect of running on a Windows machine where Git mishandles symbolic links. I will definitely clean these up and re-base the PR as I progress through the management process. I look forward to your recommendations regarding sponsorship. Best regards, Gökhan |
|
You do not need to have "sponsor" before you start discussion. You will need to get someone(s) committed to overlook your maintenance - but it's a bit your job to get someone to volunteer, and likely the discussion you start should be convincing, and ideally someone who signs up should be somehow knowledgeable about it - at least somewhat. The discussion on devlist is the best way to attract someone - there is no single person that you can delegate finding who that sponsor might be to - it's really the first task of someone to commit to maintain a provider to convince a volunteer to sign up for it. And a good way to convince someone is to "do stuff". For example continue rebasing and fixing issues with your PR and making it green - this is one of the signals that you are serious about further maintenance. |
c1c8e80 to
d54a717
Compare
|
Note that build most probably fail on broken main which is fixed in parallel in #61651 |
|
Cassandra diver problems leading to failures in CI seem to be unrelated. |
|
Hi @jscheffl, The recent errors don't seem to be related to Informatica. Is it mandatory for all tests to pass for merge? |
No not needed but would be better for confidence. Last run just had a DB timeout... but last week there were still syntax errors. @potiuk You still have "request changes", once turning green, devlist discussionw as positive, can you re-review from your current response. In my view LGTM. |
|
I rerun the failed check to be sure |
|
We finally saw the green :), thank you everyone for your support from the beginning, it was a wonderful experience for me too. |
|
Thanks for all the efforts and being patient! Let's get is rolling! |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 23e980d v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
|
Besides the optional extra for Airflow core, there is actually no real core dependency. So I'd rather not back-port, which would just miss the convenience of being able to install |
Add Informatica Provider for Apache Airflow
This PR introduces a new provider for Informatica EDC, which includes:
Closes: N/A
Related: N/A
All new functionality is covered by unit tests and follows Airflow coding standards.
No new third-party dependencies are introduced.