Skip to content

Conversation

@jgoedeke
Copy link
Contributor

  • several schemas reuse the user info part from RFC 3986 e.g. AFBS
  • to protect secrets we only normalize URIs when a password is present

closes: #51877


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 31, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@jgoedeke jgoedeke force-pushed the fix-asset-uri-normalization branch from e3a369e to 8bafa5f Compare November 5, 2025 07:52
@uranusjr uranusjr added this to the Airflow 3.1.3 milestone Nov 5, 2025
@jgoedeke jgoedeke force-pushed the fix-asset-uri-normalization branch from 4a517bf to d7bb7fd Compare November 5, 2025 15:44
@jgoedeke jgoedeke force-pushed the fix-asset-uri-normalization branch 2 times, most recently from 472f5f3 to aebcb8f Compare November 10, 2025 07:12
jgoedeke and others added 2 commits November 11, 2025 08:23
)

- several schemas reuse the user info part from RFC 3986 e.g. AFBS
- to protect secrets we only normalize URIs when a password is present
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@jgoedeke jgoedeke force-pushed the fix-asset-uri-normalization branch from aebcb8f to 245811e Compare November 11, 2025 07:23
@Lee-W Lee-W added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Nov 19, 2025
@uranusjr uranusjr merged commit dbdefc1 into apache:main Nov 19, 2025
84 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 19, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

github-actions bot pushed a commit that referenced this pull request Nov 19, 2025
#51877) (#57650)

(cherry picked from commit dbdefc1)

Co-authored-by: jgoedeke <jan.goedeke@pilatus-aircraft.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@github-actions
Copy link

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Nov 19, 2025
apache#51877) (apache#57650)

(cherry picked from commit dbdefc1)

Co-authored-by: jgoedeke <jan.goedeke@pilatus-aircraft.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Lee-W pushed a commit that referenced this pull request Nov 19, 2025
#51877) (#57650)

(cherry picked from commit dbdefc1)

Co-authored-by: jgoedeke <jan.goedeke@pilatus-aircraft.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Lee-W pushed a commit to astronomer/airflow that referenced this pull request Nov 19, 2025
apache#51877) (apache#57650)

(cherry picked from commit dbdefc1)

Co-authored-by: jgoedeke <jan.goedeke@pilatus-aircraft.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Lee-W pushed a commit that referenced this pull request Nov 19, 2025
#51877) (#57650) (#58485)

Co-authored-by: jgoedeke <jan.goedeke@pilatus-aircraft.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
ephraimbuddy pushed a commit that referenced this pull request Nov 20, 2025
#51877) (#57650) (#58485)

Co-authored-by: jgoedeke <jan.goedeke@pilatus-aircraft.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
aaron-wolmutt pushed a commit to aaron-wolmutt/airflow that referenced this pull request Nov 20, 2025
ephraimbuddy pushed a commit that referenced this pull request Dec 3, 2025
#51877) (#57650) (#58485)

Co-authored-by: jgoedeke <jan.goedeke@pilatus-aircraft.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdk backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Asset creation from an ObjectStoragePath doesn't work if a Connection is in use

4 participants