Skip to content

Add number of queries guard for ui backfill #57820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 1 commit into from
Nov 5, 2025
Merged

Add number of queries guard for ui backfill #57820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion airflow-core/src/airflow/api_fastapi/core_api/routes/ui/backfills.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

from fastapi import Depends, status
from sqlalchemy import select
from sqlalchemy.orm import joinedload

from airflow.api_fastapi.common.db.common import SessionDep, paginated_select
from airflow.api_fastapi.common.parameters import (
Expand Down Expand Up @@ -64,7 +65,7 @@ def list_backfills_ui(
],
) -> BackfillCollectionResponse:
select_stmt, total_entries = paginated_select(
statement=select(Backfill),
statement=select(Backfill).options(joinedload(Backfill.dag_model)),
filters=[dag_id, active],
order_by=order_by,
offset=offset,
Expand Down
4 changes: 3 additions & 1 deletion airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_backfills.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from airflow.models.backfill import Backfill
from airflow.utils.session import provide_session

from tests_common.test_utils.asserts import assert_queries_count
from tests_common.test_utils.db import (
clear_db_backfills,
clear_db_dag_bundles,
Expand Down Expand Up @@ -152,7 +153,8 @@ def test_should_response_200(
expected_response = []
for backfill in response_params:
expected_response.append(backfill_responses[backfill])
response = test_client.get("/backfills", params=test_params)
with assert_queries_count(2):
response = test_client.get("/backfills", params=test_params)
assert response.status_code == 200
assert response.json() == {
"backfills": expected_response,
Expand Down
Loading