Skip to content

Revert "Fix text selection jumping in logs pane to match text editor behavior" #57873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 1 commit into from
Nov 5, 2025
Merged

Revert "Fix text selection jumping in logs pane to match text editor behavior" #57873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 2 additions & 23 deletions airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,6 @@ export const TaskLogContent = ({ error, isLoading, logError, parsedLogs, wrap }:
}
}, [isLoading, rowVirtualizer, hash, parsedLogs]);

useLayoutEffect(() => {
// Force remeasurement when wrap changes since item heights will change
rowVirtualizer.measure();
}, [wrap, rowVirtualizer]);

const handleScrollTo = (to: "bottom" | "top") => {
if (parsedLogs.length > 0) {
rowVirtualizer.scrollToIndex(to === "bottom" ? parsedLogs.length - 1 : 0);
Expand All @@ -131,17 +126,10 @@ export const TaskLogContent = ({ error, isLoading, logError, parsedLogs, wrap }:
position="relative"
py={3}
ref={parentRef}
textWrap={wrap ? "pre-wrap" : "nowrap"}
textWrap={wrap ? "pre" : "nowrap"}
width="100%"
>
<VStack
alignItems="flex-start"
gap={0}
h={`${rowVirtualizer.getTotalSize()}px`}
minH="100%"
position="relative"
width="100%"
>
<VStack alignItems="flex-start" gap={0} h={`${rowVirtualizer.getTotalSize()}px`}>
{rowVirtualizer.getVirtualItems().map((virtualRow) => (
<Box
_ltr={{
Expand All @@ -158,7 +146,6 @@ export const TaskLogContent = ({ error, isLoading, logError, parsedLogs, wrap }:
data-index={virtualRow.index}
data-testid={`virtualized-item-${virtualRow.index}`}
key={virtualRow.key}
minWidth="100%"
position="absolute"
ref={rowVirtualizer.measureElement}
top={`${virtualRow.start}px`}
Expand All @@ -167,14 +154,6 @@ export const TaskLogContent = ({ error, isLoading, logError, parsedLogs, wrap }:
{parsedLogs[virtualRow.index] ?? undefined}
</Box>
))}
<Box
bottom={0}
left={0}
minH={`calc(100% - ${rowVirtualizer.getTotalSize()}px)`}
position="absolute"
top={`${rowVirtualizer.getTotalSize()}px`}
width="100%"
/>
</VStack>
</Code>

Expand Down