-
Notifications
You must be signed in to change notification settings - Fork 16.3k
UI Fix for backfill date picker #57880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… object and convert it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks your for the PR.
I tried your change locally and the issue seems to persist for years on my end. Are you using a specific browser for this to work?
I have attached a video. When I edit the time, day or month, everything is fine, when I edit the year, (I tried to input 2024), it resets to 1902then 1900, then 1902, then 1904. (only the last digit is taken into account). Same if I hit delete year before trying a new input value.
Screen.Recording.2025-11-07.at.16.49.15.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tomi-1997 Thanks for your reply.
I understand that this pull request is fixing the 'other fields' flickering, but the 'year' field remain bugged as mentionned above. Is that outside the scope of this PR and should be treated separately or is this PR supposed to also address that ?
Maybe we can go ahead and merge this fix and follow up with another PR to fix specifically the year field?
|
@pierrejeambrun |
|
Nice. Weird there is not the CI backport automatic message, as if the backport was not done. |
… object and convert it (apache#57880)
… object and convert it (apache#57880)

Fixes Backfill date picker randomly changing the date when it is full and then modified.
Closes: #57544
Problem
Solution
Create day.js from date string
Convert with timezone to another day.js
Create day.js using date string and a timezone
I think consecutive conversions causes an offset to be added, but this seems to fix it.
This keeps the same behavior as before (value as utc, display value as local time)