Ensure task in the context is always correct.
#57884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
approved these changes
Nov 5, 2025
vatsrahul1001
added
the
backport-to-v3-1-test
phanikumv
approved these changes
Nov 5, 2025
amoghrajesh
approved these changes
Nov 5, 2025
Contributor
|
Thanks, that's a critical fix from the listener perspective ! |
This comment was marked as resolved.
This comment was marked as resolved.
As part of the fix in apache#54568 we made `ti.get_runtime_context()` return a cached context key, which meant that when `run()` in the TaskSDK created a copy via `task.prepare_for_execution()` the value previously in the context was the previous copy. Most of the time this doesn't matter, as the task object that is executed is the correct value, it's just this is more correct for things like listeners.
ashb
force-pushed
the
update-task-ti-cached--context
branch
from
ed48efc to
dd72e36
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
Ensure `task` in the context is always correct. (cherry picked from commit 07e6ad7) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
Backport successfully created: v3-1-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Nov 5, 2025
xchwan
pushed a commit
to xchwan/airflow
that referenced
this pull request
Nov 6, 2025
Ensure `task` in the context is always correct.
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
Ensure `task` in the context is always correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the fix in #54568 we made
ti.get_runtime_context()return acached context key, which meant that when
run()in the TaskSDK created acopy via
task.prepare_for_execution()the value previously in the contextwas the previous copy.
Most of the time this doesn't matter, as the task object that is executed is
the correct value, it's just this is more correct for things like listeners.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.