Skip to content

Add number of queries guard for ui dashboard #57956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 1 commit into from
Nov 6, 2025
Merged

Add number of queries guard for ui dashboard #57956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
from airflow.utils.state import DagRunState, TaskInstanceState
from airflow.utils.types import DagRunType

from tests_common.test_utils.asserts import assert_queries_count
from tests_common.test_utils.db import clear_db_runs

pytestmark = pytest.mark.db_test
Expand Down Expand Up @@ -309,7 +310,8 @@ class TestHistoricalMetricsDataEndpoint:
)
@pytest.mark.usefixtures("freeze_time_for_dagruns", "make_dag_runs")
def test_should_response_200(self, test_client, params, expected):
response = test_client.get("/dashboard/historical_metrics_data", params=params)
with assert_queries_count(4):
response = test_client.get("/dashboard/historical_metrics_data", params=params)
assert response.status_code == 200
assert response.json() == expected

Expand All @@ -329,7 +331,8 @@ def test_should_response_403(self, unauthorized_test_client):
class TestDagStatsEndpoint:
@pytest.mark.usefixtures("freeze_time_for_dagruns", "make_multiple_dags")
def test_should_response_200_multiple_dags(self, test_client):
response = test_client.get("/dashboard/dag_stats")
with assert_queries_count(3):
response = test_client.get("/dashboard/dag_stats")
assert response.status_code == 200
assert response.json() == {
"active_dag_count": 4,
Expand All @@ -340,7 +343,8 @@ def test_should_response_200_multiple_dags(self, test_client):

@pytest.mark.usefixtures("freeze_time_for_dagruns", "make_dag_runs")
def test_should_response_200_single_dag(self, test_client):
response = test_client.get("/dashboard/dag_stats")
with assert_queries_count(3):
response = test_client.get("/dashboard/dag_stats")
assert response.status_code == 200
assert response.json() == {
"active_dag_count": 1,
Expand All @@ -351,7 +355,8 @@ def test_should_response_200_single_dag(self, test_client):

@pytest.mark.usefixtures("freeze_time_for_dagruns", "make_failed_dag_runs")
def test_should_response_200_failed_dag(self, test_client):
response = test_client.get("/dashboard/dag_stats")
with assert_queries_count(3):
response = test_client.get("/dashboard/dag_stats")
assert response.status_code == 200
assert response.json() == {
"active_dag_count": 1,
Expand All @@ -362,7 +367,8 @@ def test_should_response_200_failed_dag(self, test_client):

@pytest.mark.usefixtures("freeze_time_for_dagruns", "make_queued_dag_runs")
def test_should_response_200_queued_dag(self, test_client):
response = test_client.get("/dashboard/dag_stats")
with assert_queries_count(3):
response = test_client.get("/dashboard/dag_stats")
assert response.status_code == 200
assert response.json() == {
"active_dag_count": 1,
Expand All @@ -373,7 +379,8 @@ def test_should_response_200_queued_dag(self, test_client):

@pytest.mark.usefixtures("freeze_time_for_dagruns")
def test_should_response_200_no_dag_runs(self, test_client):
response = test_client.get("/dashboard/dag_stats")
with assert_queries_count(3):
response = test_client.get("/dashboard/dag_stats")
assert response.status_code == 200
assert response.json() == {
"active_dag_count": 0,
Expand Down
Loading