Fix bug on the state and run_type filter for Dag Runs page #58093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pei-Cheng-Yu
requested review from
bbovenzi,
guan404ming,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
guan404ming
force-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
b6aebba to
be85bf5
Compare
Member
|
Could you help resolve the static check error? Thanks! |
Pei-Cheng-Yu
force-pushed
the
fix-dag_run-filter-error-with-all_state
branch
from
be85bf5 to
916ae85
Compare
Contributor
Author
|
HI @guan404ming, thanks for the review. I have resolved the static check error. |
Contributor
Author
|
Hi @guan404ming, thank you for the approval! |
bbovenzi
added
the
backport-to-v3-1-test
bbovenzi
approved these changes
Nov 20, 2025
bbovenzi
removed
the
backport-to-v3-1-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
related: #53043
While working on the Task Instances counterpart( #56920 just for ref ), I encountered a similar issue with the “All” option.
On the Dag Runs page, selecting All for State and/or Run Type currently sends values that the backend interprets as real filters, which leads to an error. The "All" option should clear the filter, instead of sends values as filters option
picture:
HOW
The filter logic now clears the value for the filter itself rather than passing it as a filter value , without affecting other active filters.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.