Add dummy Fernet key for integration tests #58112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugraoz93
requested review from
amoghrajesh,
ashb,
gopidesupavan,
jason810496,
jscheffl,
kaxil and
potiuk
as code owners
bugraoz93
force-pushed
the
add-dummy-fernet-key-to-integration-tests
branch
2 times, most recently
from
c387fc5 to
043f081
Compare
Contributor
|
As via slack: I think we should discuss first how we handle this not to have security side-effects |
Member
|
Yeah. I think yeah - we should get some good agreement, but for now setting the key seem a good idea ? |
potiuk
added
full tests needed
potiuk
force-pushed
the
add-dummy-fernet-key-to-integration-tests
branch
from
043f081 to
3df0ad5
Compare
Member
|
Added version/tests labels. |
potiuk
approved these changes
Nov 9, 2025
amoghrajesh
reviewed
Nov 11, 2025
bugraoz93
force-pushed
the
add-dummy-fernet-key-to-integration-tests
branch
2 times, most recently
from
0a742d6 to
ef14b13
Compare
potiuk
reviewed
Nov 12, 2025
bugraoz93
force-pushed
the
add-dummy-fernet-key-to-integration-tests
branch
from
ef14b13 to
6f4db09
Compare
…from environment variable
bugraoz93
force-pushed
the
add-dummy-fernet-key-to-integration-tests
branch
from
6f4db09 to
faf79d2
Compare
jscheffl
approved these changes
Nov 16, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
For me this looks good now!
Even once merged could we still start re-considering dropping the NullFernet? (Otherwise print a BIIIIG Banner if used...
___________________
< Big Banner, yeah! >
-------------------
\ ^__^
\ (oo)\_______
(__)\ )\/\
||----w |
|| ||
Member
Contributor
Author
|
I agree. We should definitely have it where we can for sure reconsider. I will nudge people for another round and will start a lazy consensus on it while creating those follow-ups :) |
jason810496
approved these changes
Nov 17, 2025
potiuk
approved these changes
Nov 17, 2025
aaron-wolmutt
pushed a commit
to aaron-wolmutt/airflow
that referenced
this pull request
Nov 20, 2025
* Add dummy Fernet key for integration tests * dynamic fernet key generation from devel-common * Add pyyaml dependency and update YAML loading method in fernet.py * Revert integration test changes * Update integration tests to use always the same generated Fernet key from environment variable
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
* Add dummy Fernet key for integration tests * dynamic fernet key generation from devel-common * Add pyyaml dependency and update YAML loading method in fernet.py * Revert integration test changes * Update integration tests to use always the same generated Fernet key from environment variable
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
* Add dummy Fernet key for integration tests * dynamic fernet key generation from devel-common * Add pyyaml dependency and update YAML loading method in fernet.py * Revert integration test changes * Update integration tests to use always the same generated Fernet key from environment variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.