Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5211] Add pass_value to template_fields for BigQueryValueCheckOperator #5816

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

damon09273
Copy link
Contributor

@damon09273 damon09273 commented Aug 14, 2019

Make sure you have checked all steps below.

Jira

Description

  • There's use cases to fill pass_value from XCom when use BigQueryValueCheckOperator, so add pass_value to template_fields.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@mik-laj mik-laj changed the title Add pass_value to template_fields for BigQueryValueCheckOperator [AIRFLOW-5211] Add pass_value to template_fields for BigQueryValueCheckOperator Aug 14, 2019
@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Aug 14, 2019
@mik-laj mik-laj merged commit 7935e93 into apache:master Aug 14, 2019
kaxil pushed a commit that referenced this pull request Aug 30, 2019
kaxil pushed a commit that referenced this pull request Aug 30, 2019
kaxil pushed a commit that referenced this pull request Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants