Skip to content

Fix Enum-str interpolation in callback metrics in Python 3.11+ #58168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jason810496 merged 1 commit into from
Nov 11, 2025
Merged

Fix Enum-str interpolation in callback metrics in Python 3.11+ #58168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion airflow-core/src/airflow/models/callback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ class CallbackState(str, Enum):
SUCCESS = "success"
FAILED = "failed"

def __str__(self) -> str:
return self.value


ACTIVE_STATES = frozenset((CallbackState.QUEUED, CallbackState.RUNNING))
TERMINAL_STATES = frozenset((CallbackState.SUCCESS, CallbackState.FAILED))
Expand Down Expand Up @@ -153,7 +156,7 @@ def __init__(self, priority_weight: int = 1, prefix: str = "", **kwargs):
def queue(self):
self.state = CallbackState.QUEUED

def get_metric_info(self, status: str, result: Any) -> dict:
def get_metric_info(self, status: CallbackState, result: Any) -> dict:
tags = {"result": result, **self.data}
tags.pop("prefix", None)

Expand Down
6 changes: 3 additions & 3 deletions airflow-core/tests/unit/models/test_callback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ class UnknownCallback:
def test_get_metric_info(self):
callback = TriggererCallback(TEST_ASYNC_CALLBACK, prefix="deadline_alerts", dag_id=TEST_DAG_ID)
callback.data["kwargs"] = {"context": {"dag_id": TEST_DAG_ID}, "email": "test@example.com"}
metric_info = callback.get_metric_info(CallbackState.SUCCESS.value, "0")
metric_info = callback.get_metric_info(CallbackState.SUCCESS, "0")

assert metric_info["stat"] == "deadline_alerts.callback_success"
assert metric_info["tags"] == {
Expand All @@ -122,7 +122,7 @@ def test_polymorphic_serde(self, session):
assert isinstance(retrieved, TriggererCallback)
assert retrieved.fetch_method == CallbackFetchMethod.IMPORT_PATH
assert retrieved.data == TEST_ASYNC_CALLBACK.serialize()
assert retrieved.state == CallbackState.PENDING
assert retrieved.state == CallbackState.PENDING.value
assert retrieved.output is None
assert retrieved.priority_weight == 1
assert retrieved.created_at is not None
Expand Down Expand Up @@ -192,7 +192,7 @@ def test_polymorphic_serde(self, session):
assert isinstance(retrieved, ExecutorCallback)
assert retrieved.fetch_method == CallbackFetchMethod.IMPORT_PATH
assert retrieved.data == TEST_SYNC_CALLBACK.serialize()
assert retrieved.state == CallbackState.PENDING
assert retrieved.state == CallbackState.PENDING.value
assert retrieved.output is None
assert retrieved.priority_weight == 1
assert retrieved.created_at is not None
Expand Down