Skip to content

fix: add required arguments when creating an external table #58199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Nov 13, 2025
Merged

fix: add required arguments when creating an external table #58199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions providers/google/src/airflow/providers/google/cloud/transfers/gcs_to_bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,6 +593,8 @@ def _create_external_table(self):
self.hook.create_table(
table_resource=table_obj_api_repr,
project_id=self.project_id or self.hook.project_id,
dataset_id=table.dataset_id,
table_id=table.table_id,
location=self.location,
exists_ok=True,
)
Expand Down
47 changes: 47 additions & 0 deletions providers/google/tests/unit/google/cloud/transfers/test_gcs_to_bigquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ def test_max_value_external_table_should_execute_successfully(self, hook):
exists_ok=True,
location=None,
project_id=JOB_PROJECT_ID,
dataset_id=DATASET,
table_id=TABLE,
table_resource={
"tableReference": {"projectId": PROJECT_ID, "datasetId": DATASET, "tableId": TABLE},
"labels": {},
Expand Down Expand Up @@ -155,6 +157,33 @@ def test_max_value_external_table_should_execute_successfully(self, hook):
project_id=JOB_PROJECT_ID,
)

@mock.patch(GCS_TO_BQ_PATH.format("BigQueryHook"))
def test_external_table_explicitly_passes_dataset_and_table_ids(self, hook):
hook.return_value.insert_job.side_effect = [
MagicMock(job_id=REAL_JOB_ID, error_result=False),
REAL_JOB_ID,
]
hook.return_value.generate_job_id.return_value = REAL_JOB_ID
hook.return_value.split_tablename.return_value = (PROJECT_ID, DATASET, TABLE)

def _validate_create_table(**kwargs):
assert kwargs["dataset_id"] == DATASET
assert kwargs["table_id"] == TABLE

hook.return_value.create_table.side_effect = _validate_create_table

operator = GCSToBigQueryOperator(
task_id=TASK_ID,
bucket=TEST_BUCKET,
source_objects=TEST_SOURCE_OBJECTS,
destination_project_dataset_table=TEST_EXPLICIT_DEST,
schema_fields=SCHEMA_FIELDS,
external_table=True,
project_id=JOB_PROJECT_ID,
)

operator.execute(context=MagicMock())

@mock.patch(GCS_TO_BQ_PATH.format("BigQueryHook"))
def test_max_value_without_external_table_should_execute_successfully(self, hook):
hook.return_value.insert_job.side_effect = [
Expand Down Expand Up @@ -333,6 +362,8 @@ def test_labels_external_table_should_execute_successfully(self, hook):
exists_ok=True,
location=None,
project_id=JOB_PROJECT_ID,
dataset_id=DATASET,
table_id=TABLE,
table_resource={
"tableReference": {"projectId": PROJECT_ID, "datasetId": DATASET, "tableId": TABLE},
"labels": LABELS,
Expand Down Expand Up @@ -434,6 +465,8 @@ def test_description_external_table_should_execute_successfully(self, hook):
exists_ok=True,
location=None,
project_id=JOB_PROJECT_ID,
dataset_id=DATASET,
table_id=TABLE,
table_resource={
"tableReference": {"projectId": PROJECT_ID, "datasetId": DATASET, "tableId": TABLE},
"labels": {},
Expand Down Expand Up @@ -536,6 +569,8 @@ def test_source_objs_as_list_external_table_should_execute_successfully(self, ho
exists_ok=True,
location=None,
project_id=JOB_PROJECT_ID,
dataset_id=DATASET,
table_id=TABLE,
table_resource={
"tableReference": {"projectId": PROJECT_ID, "datasetId": DATASET, "tableId": TABLE},
"labels": {},
Expand Down Expand Up @@ -640,6 +675,8 @@ def test_source_objs_as_string_external_table_should_execute_successfully(self,
exists_ok=True,
location=None,
project_id=JOB_PROJECT_ID,
dataset_id=DATASET,
table_id=TABLE,
table_resource={
"tableReference": {"projectId": PROJECT_ID, "datasetId": DATASET, "tableId": TABLE},
"labels": {},
Expand Down Expand Up @@ -745,6 +782,8 @@ def test_schema_obj_external_table_should_execute_successfully(self, bq_hook, gc
exists_ok=True,
location=None,
project_id=JOB_PROJECT_ID,
dataset_id=DATASET,
table_id=TABLE,
table_resource={
"tableReference": {"projectId": PROJECT_ID, "datasetId": DATASET, "tableId": TABLE},
"labels": {},
Expand Down Expand Up @@ -849,6 +888,8 @@ def test_autodetect_none_external_table_should_execute_successfully(self, hook):
exists_ok=True,
location=None,
project_id=JOB_PROJECT_ID,
dataset_id=DATASET,
table_id=TABLE,
table_resource={
"tableReference": {"projectId": PROJECT_ID, "datasetId": DATASET, "tableId": TABLE},
"labels": {},
Expand Down Expand Up @@ -1051,6 +1092,8 @@ def test_schema_fields_integer_scanner_external_table_should_execute_successfull
exists_ok=True,
location=None,
project_id=JOB_PROJECT_ID,
dataset_id=DATASET,
table_id=TABLE,
table_resource={
"tableReference": {"projectId": PROJECT_ID, "datasetId": DATASET, "tableId": TABLE},
"labels": {},
Expand Down Expand Up @@ -1235,6 +1278,8 @@ def test_schema_fields_external_table_should_execute_successfully(self, hook):
exists_ok=True,
location=None,
project_id=JOB_PROJECT_ID,
dataset_id=DATASET,
table_id=TABLE,
table_resource={
"tableReference": {"projectId": PROJECT_ID, "datasetId": DATASET, "tableId": TABLE},
"labels": {},
Expand Down Expand Up @@ -1616,6 +1661,8 @@ def test_external_table_should_accept_orc_source_format(self, hook):
exists_ok=True,
location=None,
project_id=JOB_PROJECT_ID,
dataset_id=DATASET,
table_id=TABLE,
table_resource={
"tableReference": {
"projectId": PROJECT_ID,
Expand Down