[v3-1-test] Fix the __init__.py for tests (#58211)
#58213
Merged
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:providers
backport-to-v3-1-test
Member
|
No need to backport. |
Member
|
I think we do need it after all, or something changed: |
This was referenced Dec 1, 2025
The `__init__.py` for tests should have the legacy namespaces defined in order for IDE imports to work properly. This works also in IDEs where `tests` folders are added the path of ours (this is done via `setup_idea.py` and `setup_vscode.py`). There was a bug in our prek hook wher it did not have "expected" and "namespace" __init__.py for those known test folders. This PR fixes the prek hook and some of the recently added folders that had wrong __init__.py added. (cherry picked from commit 80c2ccc) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
pierrejeambrun
force-pushed
the
backport-80c2ccc-v3-1-test
branch
from
68d18d6 to
557c71c
Compare
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
The `__init__.py` for tests should have the legacy namespaces defined in order for IDE imports to work properly. This works also in IDEs where `tests` folders are added the path of ours (this is done via `setup_idea.py` and `setup_vscode.py`). There was a bug in our prek hook wher it did not have "expected" and "namespace" __init__.py for those known test folders. This PR fixes the prek hook and some of the recently added folders that had wrong __init__.py added. (cherry picked from commit 80c2ccc) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__init__.pyfor tests should have the legacy namespacesdefined in order for IDE imports to work properly. This works also
in IDEs where
testsfolders are added the path of ours (thisis done via
setup_idea.pyandsetup_vscode.py).There was a bug in our prek hook wher it did not have "expected"
and "namespace" init.py for those known test folders.
This PR fixes the prek hook and some of the recently added
folders that had wrong init.py added.
(cherry picked from commit 80c2ccc)
Co-authored-by: Jarek Potiuk jarek@potiuk.com