-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix operator extra links not appearing on failed tasks #58227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lee-W
merged 2 commits into
apache:main
from
astronomer:fix-operator-extra-links-failed-tasks
Nov 20, 2025
Merged
Fix operator extra links not appearing on failed tasks #58227
Lee-W
merged 2 commits into
apache:main
from
astronomer:fix-operator-extra-links-failed-tasks
Nov 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e930cbc to
6e657fd
Compare
Lee-W
reviewed
Nov 19, 2025
Member
Lee-W
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly good, a few nits
amoghrajesh
approved these changes
Nov 19, 2025
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good find, i didn't think this would be the source. One nit and comments from Wei
cc93589 to
c00df8a
Compare
Lee-W
approved these changes
Nov 20, 2025
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Nov 20, 2025
…pache#58227) (cherry picked from commit 302bb4f) Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
aaron-wolmutt
pushed a commit
to aaron-wolmutt/airflow
that referenced
this pull request
Nov 20, 2025
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator extra links were not appearing in the UI for failed tasks in Airflow 3, which was a regression from Airflow 2 behaviour.
Root Cause
The
finalize()function callsget_link()for each operator extra link without exception handling. Ifget_link()raises an exception (e.g., when accessing xcoms that don't exist for failed tasks), the entire loop stops and no xcoms are pushed.Fix
Added exception handling around
get_link()calls so that:Fixes #57545
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.