-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix import errors not cleared for files without DAGs #58242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ephraimbuddy
merged 7 commits into
apache:main
from
astronomer:fix-import-error-file-nolonger-exists
Nov 25, 2025
Merged
Fix import errors not cleared for files without DAGs #58242
ephraimbuddy
merged 7 commits into
apache:main
from
astronomer:fix-import-error-file-nolonger-exists
Nov 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2a8388 to
05cf4ea
Compare
uranusjr
reviewed
Nov 13, 2025
uranusjr
reviewed
Nov 13, 2025
uranusjr
reviewed
Nov 13, 2025
uranusjr
reviewed
Nov 13, 2025
b591282 to
a52bc30
Compare
a52bc30 to
519b2af
Compare
Previously, import errors persisted in the database for files that were successfully parsed but no longer contained any DAGs. This happened because we only tracked files that had DAGs, missing files that were parsed successfully but had their DAGs removed. Now, when files are parsed, all parsed files are tracked (not just those with DAGs), ensuring import errors are properly cleared when a file is successfully parsed without errors, even if it no longer contains DAGs. closes: apache#57621
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
28e8d14 to
a2847cb
Compare
phanikumv
approved these changes
Nov 25, 2025
vatsrahul1001
approved these changes
Nov 25, 2025
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 796b46e v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
* Fix import errors not cleared for files without DAGs Previously, import errors persisted in the database for files that were successfully parsed but no longer contained any DAGs. This happened because we only tracked files that had DAGs, missing files that were parsed successfully but had their DAGs removed. Now, when files are parsed, all parsed files are tracked (not just those with DAGs), ensuring import errors are properly cleared when a file is successfully parsed without errors, even if it no longer contains DAGs. closes: apache#57621 * Apply suggestions from code review Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> * fixup! Fix import errors not cleared for files without DAGs * Remove fallback for files_parsed * fixup! fixup! Fix import errors not cleared for files without DAGs * fixup! Remove fallback for files_parsed * fixup! fixup! fixup! Fix import errors not cleared for files without DAGs --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
* Fix import errors not cleared for files without DAGs Previously, import errors persisted in the database for files that were successfully parsed but no longer contained any DAGs. This happened because we only tracked files that had DAGs, missing files that were parsed successfully but had their DAGs removed. Now, when files are parsed, all parsed files are tracked (not just those with DAGs), ensuring import errors are properly cleared when a file is successfully parsed without errors, even if it no longer contains DAGs. closes: apache#57621 * Apply suggestions from code review Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> * fixup! Fix import errors not cleared for files without DAGs * Remove fallback for files_parsed * fixup! fixup! Fix import errors not cleared for files without DAGs * fixup! Remove fallback for files_parsed * fixup! fixup! fixup! Fix import errors not cleared for files without DAGs --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
|
Any idea, when this will be released? I checked latest 3.1.4 and 3.1.5 and fix is not there. |
ephraimbuddy
added a commit
that referenced
this pull request
Dec 16, 2025
) * Fix import errors not cleared for files without DAGs Previously, import errors persisted in the database for files that were successfully parsed but no longer contained any DAGs. This happened because we only tracked files that had DAGs, missing files that were parsed successfully but had their DAGs removed. Now, when files are parsed, all parsed files are tracked (not just those with DAGs), ensuring import errors are properly cleared when a file is successfully parsed without errors, even if it no longer contains DAGs. closes: #57621 * Apply suggestions from code review Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> * fixup! Fix import errors not cleared for files without DAGs * Remove fallback for files_parsed * fixup! fixup! Fix import errors not cleared for files without DAGs * fixup! Remove fallback for files_parsed * fixup! fixup! fixup! Fix import errors not cleared for files without DAGs --------- (cherry picked from commit 796b46e) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
ephraimbuddy
added a commit
that referenced
this pull request
Dec 16, 2025
) (#59500) * Fix import errors not cleared for files without DAGs Previously, import errors persisted in the database for files that were successfully parsed but no longer contained any DAGs. This happened because we only tracked files that had DAGs, missing files that were parsed successfully but had their DAGs removed. Now, when files are parsed, all parsed files are tracked (not just those with DAGs), ensuring import errors are properly cleared when a file is successfully parsed without errors, even if it no longer contains DAGs. closes: #57621 * Apply suggestions from code review * fixup! Fix import errors not cleared for files without DAGs * Remove fallback for files_parsed * fixup! fixup! Fix import errors not cleared for files without DAGs * fixup! Remove fallback for files_parsed * fixup! fixup! fixup! Fix import errors not cleared for files without DAGs --------- (cherry picked from commit 796b46e) Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
ephraimbuddy
added a commit
that referenced
this pull request
Jan 6, 2026
) (#59500) * Fix import errors not cleared for files without DAGs Previously, import errors persisted in the database for files that were successfully parsed but no longer contained any DAGs. This happened because we only tracked files that had DAGs, missing files that were parsed successfully but had their DAGs removed. Now, when files are parsed, all parsed files are tracked (not just those with DAGs), ensuring import errors are properly cleared when a file is successfully parsed without errors, even if it no longer contains DAGs. closes: #57621 * Apply suggestions from code review * fixup! Fix import errors not cleared for files without DAGs * Remove fallback for files_parsed * fixup! fixup! Fix import errors not cleared for files without DAGs * fixup! Remove fallback for files_parsed * fixup! fixup! fixup! Fix import errors not cleared for files without DAGs --------- (cherry picked from commit 796b46e) Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, import errors persisted in the database for files that were successfully parsed but no longer contained any DAGs. This happened because we only tracked files that had DAGs, missing files that were parsed successfully but had their DAGs removed.
Now, when files are parsed, all parsed files are tracked (not just those with DAGs), ensuring import errors are properly cleared when a file is successfully parsed without errors, even if it no longer contains DAGs.
closes: #57621