Skip to content

Conversation

@ephraimbuddy
Copy link
Contributor

Previously, import errors persisted in the database for files that were successfully parsed but no longer contained any DAGs. This happened because we only tracked files that had DAGs, missing files that were parsed successfully but had their DAGs removed.

Now, when files are parsed, all parsed files are tracked (not just those with DAGs), ensuring import errors are properly cleared when a file is successfully parsed without errors, even if it no longer contains DAGs.

closes: #57621

@ephraimbuddy ephraimbuddy force-pushed the fix-import-error-file-nolonger-exists branch from f2a8388 to 05cf4ea Compare November 13, 2025 05:30
@ephraimbuddy ephraimbuddy added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Nov 13, 2025
@ephraimbuddy ephraimbuddy force-pushed the fix-import-error-file-nolonger-exists branch from b591282 to a52bc30 Compare November 13, 2025 15:34
@ephraimbuddy ephraimbuddy force-pushed the fix-import-error-file-nolonger-exists branch from a52bc30 to 519b2af Compare November 18, 2025 08:09
ephraimbuddy and others added 7 commits November 25, 2025 10:53
Previously, import errors persisted in the database for files that were
successfully parsed but no longer contained any DAGs. This happened
because we only tracked files that had DAGs, missing files that
were parsed successfully but had their DAGs removed.

Now, when files are parsed, all parsed files are tracked (not just those
with DAGs), ensuring import errors are properly cleared when a file is
successfully parsed without errors, even if it no longer contains DAGs.

closes: apache#57621
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@ephraimbuddy ephraimbuddy force-pushed the fix-import-error-file-nolonger-exists branch from 28e8d14 to a2847cb Compare November 25, 2025 09:53
@ephraimbuddy ephraimbuddy merged commit 796b46e into apache:main Nov 25, 2025
64 checks passed
@ephraimbuddy ephraimbuddy deleted the fix-import-error-file-nolonger-exists branch November 25, 2025 12:13
@github-actions
Copy link

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 796b46e v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
* Fix import errors not cleared for files without DAGs

Previously, import errors persisted in the database for files that were
successfully parsed but no longer contained any DAGs. This happened
because we only tracked files that had DAGs, missing files that
were parsed successfully but had their DAGs removed.

Now, when files are parsed, all parsed files are tracked (not just those
with DAGs), ensuring import errors are properly cleared when a file is
successfully parsed without errors, even if it no longer contains DAGs.

closes: apache#57621

* Apply suggestions from code review

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>

* fixup! Fix import errors not cleared for files without DAGs

* Remove fallback for files_parsed

* fixup! fixup! Fix import errors not cleared for files without DAGs

* fixup! Remove fallback for files_parsed

* fixup! fixup! fixup! Fix import errors not cleared for files without DAGs

---------

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
* Fix import errors not cleared for files without DAGs

Previously, import errors persisted in the database for files that were
successfully parsed but no longer contained any DAGs. This happened
because we only tracked files that had DAGs, missing files that
were parsed successfully but had their DAGs removed.

Now, when files are parsed, all parsed files are tracked (not just those
with DAGs), ensuring import errors are properly cleared when a file is
successfully parsed without errors, even if it no longer contains DAGs.

closes: apache#57621

* Apply suggestions from code review

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>

* fixup! Fix import errors not cleared for files without DAGs

* Remove fallback for files_parsed

* fixup! fixup! Fix import errors not cleared for files without DAGs

* fixup! Remove fallback for files_parsed

* fixup! fixup! fixup! Fix import errors not cleared for files without DAGs

---------

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@ktaborski
Copy link

Any idea, when this will be released? I checked latest 3.1.4 and 3.1.5 and fix is not there.

@ephraimbuddy ephraimbuddy added this to the Airflow 3.1.6 milestone Dec 16, 2025
ephraimbuddy added a commit that referenced this pull request Dec 16, 2025
)

* Fix import errors not cleared for files without DAGs

Previously, import errors persisted in the database for files that were
successfully parsed but no longer contained any DAGs. This happened
because we only tracked files that had DAGs, missing files that
were parsed successfully but had their DAGs removed.

Now, when files are parsed, all parsed files are tracked (not just those
with DAGs), ensuring import errors are properly cleared when a file is
successfully parsed without errors, even if it no longer contains DAGs.

closes: #57621

* Apply suggestions from code review

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>

* fixup! Fix import errors not cleared for files without DAGs

* Remove fallback for files_parsed

* fixup! fixup! Fix import errors not cleared for files without DAGs

* fixup! Remove fallback for files_parsed

* fixup! fixup! fixup! Fix import errors not cleared for files without DAGs

---------
(cherry picked from commit 796b46e)

Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
ephraimbuddy added a commit that referenced this pull request Dec 16, 2025
) (#59500)

* Fix import errors not cleared for files without DAGs

Previously, import errors persisted in the database for files that were
successfully parsed but no longer contained any DAGs. This happened
because we only tracked files that had DAGs, missing files that
were parsed successfully but had their DAGs removed.

Now, when files are parsed, all parsed files are tracked (not just those
with DAGs), ensuring import errors are properly cleared when a file is
successfully parsed without errors, even if it no longer contains DAGs.

closes: #57621

* Apply suggestions from code review



* fixup! Fix import errors not cleared for files without DAGs

* Remove fallback for files_parsed

* fixup! fixup! Fix import errors not cleared for files without DAGs

* fixup! Remove fallback for files_parsed

* fixup! fixup! fixup! Fix import errors not cleared for files without DAGs

---------
(cherry picked from commit 796b46e)

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
ephraimbuddy added a commit that referenced this pull request Jan 6, 2026
) (#59500)

* Fix import errors not cleared for files without DAGs

Previously, import errors persisted in the database for files that were
successfully parsed but no longer contained any DAGs. This happened
because we only tracked files that had DAGs, missing files that
were parsed successfully but had their DAGs removed.

Now, when files are parsed, all parsed files are tracked (not just those
with DAGs), ensuring import errors are properly cleared when a file is
successfully parsed without errors, even if it no longer contains DAGs.

closes: #57621

* Apply suggestions from code review



* fixup! Fix import errors not cleared for files without DAGs

* Remove fallback for files_parsed

* fixup! fixup! Fix import errors not cleared for files without DAGs

* fixup! Remove fallback for files_parsed

* fixup! fixup! fixup! Fix import errors not cleared for files without DAGs

---------
(cherry picked from commit 796b46e)

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:DAG-processing backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DAG import errors from python modules are not cleared

6 participants