[v3-1-test] Add support for "reconnecting" Supervisor Comms and logs in task processes (#57212) #58263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in task processes (#57212) This change relates to #51422, #54706 and gives us a single function that we can call from the Python Virtual env script to re-connect the SUPERVISOR_COMMS and logs socket, so variables and connections are accessible from within the VEnv task, as long as task-sdk is installed. This also fixes logs produced by a venv task to not be double "encoded" (i.e. so that we directly see the actual log, not a stringification of the entire log line with two timestamps etc.) There is a matching change to the Venv script to use this function, but it is separated into a different PR so that we don't merge core/sdk and provider changes in one PR. The crux of the change in the venv operator (that I've already tested) is this ```diff +try: + from airflow.sdk.execution_time import task_runner +except ModuleNotFoundError: + pass +else: + reinit_supervisor_comms = getattr(task_runner, "reinit_supervisor_comms") + if reinit_supervisor_comms: + reinit_supervisor_comms() ``` (cherry picked from commit ff4e471) Co-authored-by: Ash Berlin-Taylor <ash@apache.org> Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 18, 2025
…in task processes (#57212) (#58263) This change relates to #51422, #54706 and gives us a single function that we can call from the Python Virtual env script to re-connect the SUPERVISOR_COMMS and logs socket, so variables and connections are accessible from within the VEnv task, as long as task-sdk is installed. This also fixes logs produced by a venv task to not be double "encoded" (i.e. so that we directly see the actual log, not a stringification of the entire log line with two timestamps etc.) There is a matching change to the Venv script to use this function, but it is separated into a different PR so that we don't merge core/sdk and provider changes in one PR. The crux of the change in the venv operator (that I've already tested) is this ```diff +try: + from airflow.sdk.execution_time import task_runner +except ModuleNotFoundError: + pass +else: + reinit_supervisor_comms = getattr(task_runner, "reinit_supervisor_comms") + if reinit_supervisor_comms: + reinit_supervisor_comms() ``` (cherry picked from commit ff4e471) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 19, 2025
…in task processes (#57212) (#58263) This change relates to #51422, #54706 and gives us a single function that we can call from the Python Virtual env script to re-connect the SUPERVISOR_COMMS and logs socket, so variables and connections are accessible from within the VEnv task, as long as task-sdk is installed. This also fixes logs produced by a venv task to not be double "encoded" (i.e. so that we directly see the actual log, not a stringification of the entire log line with two timestamps etc.) There is a matching change to the Venv script to use this function, but it is separated into a different PR so that we don't merge core/sdk and provider changes in one PR. The crux of the change in the venv operator (that I've already tested) is this ```diff +try: + from airflow.sdk.execution_time import task_runner +except ModuleNotFoundError: + pass +else: + reinit_supervisor_comms = getattr(task_runner, "reinit_supervisor_comms") + if reinit_supervisor_comms: + reinit_supervisor_comms() ``` (cherry picked from commit ff4e471) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 19, 2025
…in task processes (#57212) (#58263) This change relates to #51422, #54706 and gives us a single function that we can call from the Python Virtual env script to re-connect the SUPERVISOR_COMMS and logs socket, so variables and connections are accessible from within the VEnv task, as long as task-sdk is installed. This also fixes logs produced by a venv task to not be double "encoded" (i.e. so that we directly see the actual log, not a stringification of the entire log line with two timestamps etc.) There is a matching change to the Venv script to use this function, but it is separated into a different PR so that we don't merge core/sdk and provider changes in one PR. The crux of the change in the venv operator (that I've already tested) is this ```diff +try: + from airflow.sdk.execution_time import task_runner +except ModuleNotFoundError: + pass +else: + reinit_supervisor_comms = getattr(task_runner, "reinit_supervisor_comms") + if reinit_supervisor_comms: + reinit_supervisor_comms() ``` (cherry picked from commit ff4e471) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 20, 2025
…in task processes (#57212) (#58263) This change relates to #51422, #54706 and gives us a single function that we can call from the Python Virtual env script to re-connect the SUPERVISOR_COMMS and logs socket, so variables and connections are accessible from within the VEnv task, as long as task-sdk is installed. This also fixes logs produced by a venv task to not be double "encoded" (i.e. so that we directly see the actual log, not a stringification of the entire log line with two timestamps etc.) There is a matching change to the Venv script to use this function, but it is separated into a different PR so that we don't merge core/sdk and provider changes in one PR. The crux of the change in the venv operator (that I've already tested) is this ```diff +try: + from airflow.sdk.execution_time import task_runner +except ModuleNotFoundError: + pass +else: + reinit_supervisor_comms = getattr(task_runner, "reinit_supervisor_comms") + if reinit_supervisor_comms: + reinit_supervisor_comms() ``` (cherry picked from commit ff4e471) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
…in task processes (#57212) (#58263) This change relates to #51422, #54706 and gives us a single function that we can call from the Python Virtual env script to re-connect the SUPERVISOR_COMMS and logs socket, so variables and connections are accessible from within the VEnv task, as long as task-sdk is installed. This also fixes logs produced by a venv task to not be double "encoded" (i.e. so that we directly see the actual log, not a stringification of the entire log line with two timestamps etc.) There is a matching change to the Venv script to use this function, but it is separated into a different PR so that we don't merge core/sdk and provider changes in one PR. The crux of the change in the venv operator (that I've already tested) is this ```diff +try: + from airflow.sdk.execution_time import task_runner +except ModuleNotFoundError: + pass +else: + reinit_supervisor_comms = getattr(task_runner, "reinit_supervisor_comms") + if reinit_supervisor_comms: + reinit_supervisor_comms() ``` (cherry picked from commit ff4e471) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change relates to #51422, #54706 and gives us a single function that we can call from the Python Virtual env script to re-connect the SUPERVISOR_COMMS and logs socket, so variables and connections are accessible from within the VEnv task, as long as task-sdk is installed.
This also fixes logs produced by a venv task to not be double "encoded" (i.e. so that we directly see the actual log, not a stringification of the entire log line with two timestamps etc.)
There is a matching change to the Venv script to use this function, but it is separated into a different PR so that we don't merge core/sdk and provider changes in one PR.
The crux of the change in the venv operator (that I've already tested) is this
(cherry picked from commit ff4e471)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.