[v3-1-test] Support for "reconnecting" Supervisor Comms from task process when dag.test() is used (#58147)
#58266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cess when `dag.test()` is used (#58147) This is a follow up to #57212, which worked fine "at run time" but did not work in many of our own unit tests, which rely on `dag.test` or `ti.run`. The way this is implemented is that when we use the InProcessTestSupervisor we pre-emptively create a socket pair. We have to create it even it its not being used, as we can't know. And since this is all in one process we create a thread to handle the socket comms. Since this is only ever for tests performance or hitting the GIL doesn't matter. (cherry picked from commit 5cc2c8c) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
ashb
approved these changes
Nov 13, 2025
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 18, 2025
…cess when `dag.test()` is used (#58147) (#58266) This is a follow up to #57212, which worked fine "at run time" but did not work in many of our own unit tests, which rely on `dag.test` or `ti.run`. The way this is implemented is that when we use the InProcessTestSupervisor we pre-emptively create a socket pair. We have to create it even it its not being used, as we can't know. And since this is all in one process we create a thread to handle the socket comms. Since this is only ever for tests performance or hitting the GIL doesn't matter. (cherry picked from commit 5cc2c8c) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 19, 2025
…cess when `dag.test()` is used (#58147) (#58266) This is a follow up to #57212, which worked fine "at run time" but did not work in many of our own unit tests, which rely on `dag.test` or `ti.run`. The way this is implemented is that when we use the InProcessTestSupervisor we pre-emptively create a socket pair. We have to create it even it its not being used, as we can't know. And since this is all in one process we create a thread to handle the socket comms. Since this is only ever for tests performance or hitting the GIL doesn't matter. (cherry picked from commit 5cc2c8c) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 19, 2025
…cess when `dag.test()` is used (#58147) (#58266) This is a follow up to #57212, which worked fine "at run time" but did not work in many of our own unit tests, which rely on `dag.test` or `ti.run`. The way this is implemented is that when we use the InProcessTestSupervisor we pre-emptively create a socket pair. We have to create it even it its not being used, as we can't know. And since this is all in one process we create a thread to handle the socket comms. Since this is only ever for tests performance or hitting the GIL doesn't matter. (cherry picked from commit 5cc2c8c) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 20, 2025
…cess when `dag.test()` is used (#58147) (#58266) This is a follow up to #57212, which worked fine "at run time" but did not work in many of our own unit tests, which rely on `dag.test` or `ti.run`. The way this is implemented is that when we use the InProcessTestSupervisor we pre-emptively create a socket pair. We have to create it even it its not being used, as we can't know. And since this is all in one process we create a thread to handle the socket comms. Since this is only ever for tests performance or hitting the GIL doesn't matter. (cherry picked from commit 5cc2c8c) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
…cess when `dag.test()` is used (#58147) (#58266) This is a follow up to #57212, which worked fine "at run time" but did not work in many of our own unit tests, which rely on `dag.test` or `ti.run`. The way this is implemented is that when we use the InProcessTestSupervisor we pre-emptively create a socket pair. We have to create it even it its not being used, as we can't know. And since this is all in one process we create a thread to handle the socket comms. Since this is only ever for tests performance or hitting the GIL doesn't matter. (cherry picked from commit 5cc2c8c) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #57212, which worked fine "at run time" but did not
work in many of our own unit tests, which rely on
dag.testorti.run.The way this is implemented is that when we use the InProcessTestSupervisor we
pre-emptively create a socket pair. We have to create it even it its not being
used, as we can't know.
And since this is all in one process we create a thread to handle the socket
comms. Since this is only ever for tests performance or hitting the GIL
doesn't matter.
(cherry picked from commit 5cc2c8c)
Co-authored-by: Ash Berlin-Taylor ash@apache.org