BUGFIX: Fixed timeout_after in run_trigger method of TriggerRunner #58282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason810496
reviewed
Nov 14, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Nice catch! However, it seems the CI still needs fix, thanks!
Contributor
Author
Yes I think I closed my laptop too fast, the commit with the fix wasn't included ;-) |
Contributor
Author
CI is fixed |
jason810496
approved these changes
Nov 14, 2025
jason810496
added
the
backport-to-v3-1-test
Lee-W
approved these changes
Nov 25, 2025
Contributor
Author
|
@thx Lee for merging this! |
Member
|
Somehow it's not backported. Let me backport it manually |
Lee-W
pushed a commit
to astronomer/airflow
that referenced
this pull request
Nov 26, 2025
…gerRunner (apache#58282) (cherry picked from commit 1c3ac6c) Co-authored-by: David Blain <info@dabla.be>
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered a bug in the run_trigger method of the TriggerRunner by accident due to the fact that I added typing to the trigger parameter when working on PR #51391.
There I got the following MyPy error from the Airflow CI/CD:
First I thought I did a mistake with the typing, but after closer investigation the typing was correct and so was also the MyPy error. Then I discovered that the timeout_after attribute was indeed never part of the BaseTrigger but was part of the workloads.RunTrigger model. So I refactored the run_trigger method so that beside trigger_id and trigger (now typed as BaseTrigger), now also has the optional timeout_after parameter which is passed from the workloads.RunTrigger model.
I don't know if this has ever lead to any issue at runtime, but I would certainly lead to an exception if a trigger would be cancelled.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.