[v3-1-test] Fix config list output for multi-line values (#58115) #58378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: apache#57355 When a user runs `airflow config list --include-descriptions --include-examples`, multi-line values (like `dag_bundle_config_list`) would cause a `configparser.ParsingError` due to improper indentation. This fix pretty-prints the JSON value using `json.dumps(indent=4)` and then adds an additional four-space indent to each new line. This ensures the INI parser treats the entire block as a single, valid multi-line value. (cherry picked from commit d009b64) Co-authored-by: Aaron Chen <nailo2c@gmail.com>
potiuk
force-pushed
the
backport-d009b64-v3-1-test
branch
from
164be65 to
c286ab1
Compare
Contributor
|
Thanks! |
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 18, 2025
…8378) Closes: #57355 When a user runs `airflow config list --include-descriptions --include-examples`, multi-line values (like `dag_bundle_config_list`) would cause a `configparser.ParsingError` due to improper indentation. This fix pretty-prints the JSON value using `json.dumps(indent=4)` and then adds an additional four-space indent to each new line. This ensures the INI parser treats the entire block as a single, valid multi-line value. (cherry picked from commit d009b64) Co-authored-by: Aaron Chen <nailo2c@gmail.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 19, 2025
…8378) Closes: #57355 When a user runs `airflow config list --include-descriptions --include-examples`, multi-line values (like `dag_bundle_config_list`) would cause a `configparser.ParsingError` due to improper indentation. This fix pretty-prints the JSON value using `json.dumps(indent=4)` and then adds an additional four-space indent to each new line. This ensures the INI parser treats the entire block as a single, valid multi-line value. (cherry picked from commit d009b64) Co-authored-by: Aaron Chen <nailo2c@gmail.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 19, 2025
…8378) Closes: #57355 When a user runs `airflow config list --include-descriptions --include-examples`, multi-line values (like `dag_bundle_config_list`) would cause a `configparser.ParsingError` due to improper indentation. This fix pretty-prints the JSON value using `json.dumps(indent=4)` and then adds an additional four-space indent to each new line. This ensures the INI parser treats the entire block as a single, valid multi-line value. (cherry picked from commit d009b64) Co-authored-by: Aaron Chen <nailo2c@gmail.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 20, 2025
…8378) Closes: #57355 When a user runs `airflow config list --include-descriptions --include-examples`, multi-line values (like `dag_bundle_config_list`) would cause a `configparser.ParsingError` due to improper indentation. This fix pretty-prints the JSON value using `json.dumps(indent=4)` and then adds an additional four-space indent to each new line. This ensures the INI parser treats the entire block as a single, valid multi-line value. (cherry picked from commit d009b64) Co-authored-by: Aaron Chen <nailo2c@gmail.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
…8378) Closes: #57355 When a user runs `airflow config list --include-descriptions --include-examples`, multi-line values (like `dag_bundle_config_list`) would cause a `configparser.ParsingError` due to improper indentation. This fix pretty-prints the JSON value using `json.dumps(indent=4)` and then adds an additional four-space indent to each new line. This ensures the INI parser treats the entire block as a single, valid multi-line value. (cherry picked from commit d009b64) Co-authored-by: Aaron Chen <nailo2c@gmail.com>
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #57355
When a user runs
airflow config list --include-descriptions --include-examples, multi-line values (likedag_bundle_config_list) would cause aconfigparser.ParsingErrordue to improper indentation.This fix pretty-prints the JSON value using
json.dumps(indent=4)and then adds an additional four-space indent to each new line. This ensures the INI parser treats the entire block as a single, valid multi-line value.(cherry picked from commit d009b64)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.