56058: Removing refresh state consumption for Dag header #58389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveknanda
requested review from
bbovenzi,
guan404ming,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Thanks for the pull request.
You also need to update the behavior for other types of Header. There are multiple Header components with a similar behavior, for instance Run/Header.tsx, TaskInstance/Header.tsx and so on. We should also remove the spinner there.
Contributor
Author
@pierrejeambrun sure I will update likewise. I did ask the same question in the ticket, but given no response, I tried to be conservative and only touched this particular component. |
bbovenzi
approved these changes
Nov 25, 2025
bbovenzi
added
the
backport-to-v3-1-test
Backport successfully created: v3-1-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Nov 25, 2025
…pache#58389) * 56058: Removing refresh state consumption for Dag header * Updated formatting * 56058: Removed spinner from all headers --------- (cherry picked from commit c7a9f79) Co-authored-by: Vivek Nanda <viveknanda1984@yahoo.com> Co-authored-by: Vivek Nanda <vnanda@cloudera.com>
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
* 56058: Removing refresh state consumption for Dag header * Updated formatting * 56058: Removed spinner from all headers --------- Co-authored-by: Vivek Nanda <vnanda@cloudera.com>
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
* 56058: Removing refresh state consumption for Dag header * Updated formatting * 56058: Removed spinner from all headers --------- Co-authored-by: Vivek Nanda <vnanda@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #56058
Change in this PR aim to remove the spinner from Dag Header as suggested by @bbovenzi here
GIF
