[v3-1-test] Fix TypeError in parseStreamingLogContent for non-string data (#58314) #58399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data (#58314) The function would fail with 'TypeError: content.split is not a function' when data was not a string but also didn't have a content property. Changes: - Add type guard to check if data is string before calling .split() - Add support for single log line objects (return as array) - Simplify logic with early returns for clearer flow - Add comprehensive test suite covering all edge cases The function now handles: 1. Data with content property (returns as-is) 2. String data (parses as newline-separated JSON) 3. Object data without content (returns wrapped in array) 4. Edge cases (undefined, null, numbers, invalid JSON) (cherry picked from commit a398201) Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
potiuk
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 18, 2025
…data (#58314) (#58399) The function would fail with 'TypeError: content.split is not a function' when data was not a string but also didn't have a content property. Changes: - Add type guard to check if data is string before calling .split() - Add support for single log line objects (return as array) - Simplify logic with early returns for clearer flow - Add comprehensive test suite covering all edge cases The function now handles: 1. Data with content property (returns as-is) 2. String data (parses as newline-separated JSON) 3. Object data without content (returns wrapped in array) 4. Edge cases (undefined, null, numbers, invalid JSON) (cherry picked from commit a398201) Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 19, 2025
…data (#58314) (#58399) The function would fail with 'TypeError: content.split is not a function' when data was not a string but also didn't have a content property. Changes: - Add type guard to check if data is string before calling .split() - Add support for single log line objects (return as array) - Simplify logic with early returns for clearer flow - Add comprehensive test suite covering all edge cases The function now handles: 1. Data with content property (returns as-is) 2. String data (parses as newline-separated JSON) 3. Object data without content (returns wrapped in array) 4. Edge cases (undefined, null, numbers, invalid JSON) (cherry picked from commit a398201) Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 19, 2025
…data (#58314) (#58399) The function would fail with 'TypeError: content.split is not a function' when data was not a string but also didn't have a content property. Changes: - Add type guard to check if data is string before calling .split() - Add support for single log line objects (return as array) - Simplify logic with early returns for clearer flow - Add comprehensive test suite covering all edge cases The function now handles: 1. Data with content property (returns as-is) 2. String data (parses as newline-separated JSON) 3. Object data without content (returns wrapped in array) 4. Edge cases (undefined, null, numbers, invalid JSON) (cherry picked from commit a398201) Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 20, 2025
…data (#58314) (#58399) The function would fail with 'TypeError: content.split is not a function' when data was not a string but also didn't have a content property. Changes: - Add type guard to check if data is string before calling .split() - Add support for single log line objects (return as array) - Simplify logic with early returns for clearer flow - Add comprehensive test suite covering all edge cases The function now handles: 1. Data with content property (returns as-is) 2. String data (parses as newline-separated JSON) 3. Object data without content (returns wrapped in array) 4. Edge cases (undefined, null, numbers, invalid JSON) (cherry picked from commit a398201) Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
…data (#58314) (#58399) The function would fail with 'TypeError: content.split is not a function' when data was not a string but also didn't have a content property. Changes: - Add type guard to check if data is string before calling .split() - Add support for single log line objects (return as array) - Simplify logic with early returns for clearer flow - Add comprehensive test suite covering all edge cases The function now handles: 1. Data with content property (returns as-is) 2. String data (parses as newline-separated JSON) 3. Object data without content (returns wrapped in array) 4. Edge cases (undefined, null, numbers, invalid JSON) (cherry picked from commit a398201) Co-authored-by: Felix Uellendall <feluelle@users.noreply.github.com>
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function would fail with 'TypeError: content.split is not a function'
when data was not a string but also didn't have a content property.
Changes:
The function now handles:
(cherry picked from commit a398201)
Co-authored-by: Felix Uellendall feluelle@users.noreply.github.com