make sure the taskInstances's endDate is not null #58435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pei-Cheng-Yu
requested review from
bbovenzi,
guan404ming,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
Contributor
Author
|
Thanks for the review!! |
|
Thanks for the PR 🫶 |
bbovenzi
approved these changes
Nov 18, 2025
aaron-wolmutt
pushed a commit
to aaron-wolmutt/airflow
that referenced
this pull request
Nov 20, 2025
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 2, 2025
(cherry picked from commit 31a8636)
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
(cherry picked from commit 31a8636)
78 tasks
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
close: #58335
HOW:
The DurationChart renders a “run duration” bar only when entry.end_date is present.
For Task Instance entries, end_date is null while the task is still running.
As a result, the Task Instance overview chart does not show a running bar, and it only renders after the task finishes.
This PR makes sure that
entry.end_dateis handled when it is null, if it is null we substitute end_date with the current time (dayjs().toISOString()).^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.