Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Nov 19, 2025

Sometimes, you want to build prod image without assets being built (for example for System Tests). You can skip the check now by providing --skip-asset-compiled-check flag or corresponding env variable.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Sometimes, you want to build prod image without assets being built
(for example for System Tests). You can skip the check now by
providing --skip-asset-compiled-check flag or corresponding env
variable.
@potiuk potiuk force-pushed the add-skip-asset-compiled-check branch from 374fa15 to 9325f9a Compare November 19, 2025 01:29
Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@o-nikolas o-nikolas merged commit 53b2963 into apache:main Nov 19, 2025
118 checks passed
@github-actions
Copy link

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 53b2963 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@o-nikolas
Copy link
Contributor

Do we want to backport this one? It is pretty minor?

@amoghrajesh
Copy link
Contributor

No need to backport I think, we didn't add the change that led to this in v3 branch ig

@potiuk
Copy link
Member Author

potiuk commented Nov 19, 2025

Yeah. We already slowly stop backporting the stuff for breeze that is not really related to release - the PROD changes in images are mostly related to the "e2e" tests and we really only run them now in main - we have not backported them to v*test. We are entering the period where we will get more diverged.

I do not love it, but I think it's least of the bad things :)

We can still continue cherry-picking things that are "useful" in the v* branch.

aaron-wolmutt pushed a commit to aaron-wolmutt/airflow that referenced this pull request Nov 20, 2025
…ache#58469)

Sometimes, you want to build prod image without assets being built
(for example for System Tests). You can skip the check now by
providing --skip-asset-compiled-check flag or corresponding env
variable.
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
…ache#58469)

Sometimes, you want to build prod image without assets being built
(for example for System Tests). You can skip the check now by
providing --skip-asset-compiled-check flag or corresponding env
variable.
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
…ache#58469)

Sometimes, you want to build prod image without assets being built
(for example for System Tests). You can skip the check now by
providing --skip-asset-compiled-check flag or corresponding env
variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants