-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Skip check whether assets are compiled in PROD build from sources #58469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5bb05f7 to
374fa15
Compare
Sometimes, you want to build prod image without assets being built (for example for System Tests). You can skip the check now by providing --skip-asset-compiled-check flag or corresponding env variable.
374fa15 to
9325f9a
Compare
o-nikolas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Backport failed to create: v3-1-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 53b2963 v3-1-testThis should apply the commit to the v3-1-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
|
Do we want to backport this one? It is pretty minor? |
|
No need to backport I think, we didn't add the change that led to this in v3 branch ig |
|
Yeah. We already slowly stop backporting the stuff for breeze that is not really related to release - the PROD changes in images are mostly related to the "e2e" tests and we really only run them now in I do not love it, but I think it's least of the bad things :) We can still continue cherry-picking things that are "useful" in the v* branch. |
…ache#58469) Sometimes, you want to build prod image without assets being built (for example for System Tests). You can skip the check now by providing --skip-asset-compiled-check flag or corresponding env variable.
…ache#58469) Sometimes, you want to build prod image without assets being built (for example for System Tests). You can skip the check now by providing --skip-asset-compiled-check flag or corresponding env variable.
…ache#58469) Sometimes, you want to build prod image without assets being built (for example for System Tests). You can skip the check now by providing --skip-asset-compiled-check flag or corresponding env variable.
Sometimes, you want to build prod image without assets being built (for example for System Tests). You can skip the check now by providing --skip-asset-compiled-check flag or corresponding env variable.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.