-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Docs: Clarify that masking in Connection 'extra' JSON is keyword-dependent #58515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Clarify that masking in Connection 'extra' JSON is keyword-dependent #58515
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
… template dicts and xcom dicts
Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
bd6c2fb to
435871c
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
…ndent (apache#58515) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * Refactor import statements to use the airflow.sdk.log for mask_secret function --------- Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
…ndent (apache#58515) Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com> * Refactor import statements to use the airflow.sdk.log for mask_secret function --------- Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
Description
This PR updates the Masking Sensitive Data documentation to clarify that keys in a Connection's
extraJSON field are not masked automatically unless they contain specific sensitive keywords.Reason for Change:
Currently, the documentation states: "Airflow will by default mask Connection passwords and keys from a Connection’s extra (JSON) field..."
This implies that all keys in the
extrafield are masked by default, which is misleading. In reality, masking is triggered only if the key name contains a substring from the default sensitive keyword list (e.g.,password,secret,token).Changes in this PR:
access_token,api_key,passphrase, etc.) so users know exactly what triggers the masking.extraJSON behavior and Variable behavior.closes: #58514