-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add UI E2E testing framework with Playwright and Breeze integration #58548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI E2E testing framework with Playwright and Breeze integration #58548
Conversation
)" This reverts commit 416c73e.
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! 🎉
Just a few suggestion / improvement but I think this is a solid base!
airflow-core/src/airflow/ui/tests/e2e/specs/dag-trigger.spec.ts
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/tests/e2e/specs/dag-trigger.spec.ts
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/tests/e2e/specs/dag-trigger.spec.ts
Outdated
Show resolved
Hide resolved
|
We probably also should git ignore reports and test results |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm having trouble running all 3 on my end.
It's a bit flaky. Basically commands without the --project options are broken.
Some errors (but I can't reproduce consistently)

When I run them separately with:
breeze testing ui-e2e-tests --browser firefox --headed
All 3 are working.
Just a few adjustments and we can merge. We will see the flakiness when we integrate this to the CI.
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
#protm
|
This is cool. But there are two follow up questions:
I think it should at least be explained as a prerequisite or installed automatically. Generally
|
|
Thanks for raising this @potiuk I will raise PR to handle this today.
Yes, the plan is to create a CI workflow that will deploy an Airflow instance and run these tests. I will create a follow-up PR for this soon. |
|
PR to install pnpm if not already installed. |
…pache#58548) Add UI E2E testing framework with Playwright and Breeze integration (apache#58548)
…pache#58548) Add UI E2E testing framework with Playwright and Breeze integration (apache#58548)
…pache#58548) Add UI E2E testing framework with Playwright and Breeze integration (apache#58548)

Adds UI end-to-end testing framework using Playwright, integrated with Breeze.
breeze testing ui-e2e-testscommand for UI automation testsbreeze testing ui-e2e-tests --test-pattern "dag-trigger.spec.ts" --headed^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.