Skip to content

Remove global from listeners #58597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 1 commit into from
Nov 23, 2025
Merged

Remove global from listeners #58597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions airflow-core/src/airflow/listeners/listener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
from __future__ import annotations

import logging
from functools import cache
from typing import TYPE_CHECKING

import pluggy
Expand All @@ -30,9 +31,6 @@
log = logging.getLogger(__name__)


_listener_manager: ListenerManager | None = None


def _before_hookcall(hook_name, hook_impls, kwargs):
log.debug("Calling %r with %r", hook_name, kwargs)
log.debug("Hook impls: %s", hook_impls)
Expand Down Expand Up @@ -82,10 +80,9 @@ def clear(self):
self.pm.unregister(plugin)


@cache
def get_listener_manager() -> ListenerManager:
"""Get singleton listener manager."""
global _listener_manager
if not _listener_manager:
_listener_manager = ListenerManager()
integrate_listener_plugins(_listener_manager)
_listener_manager = ListenerManager()
integrate_listener_plugins(_listener_manager)
return _listener_manager