Skip to content

Conversation

@stuart23
Copy link
Contributor

HITL Approve UI does not correctly display object DAG parameters. These were being displayed as [object Object] (see below).

image

Main change (hitl.ts):

  • Added support for preloading parameter values from URL query strings
  • Added JSON parsing for string values that look like JSON objects
  • Fixed type detection to correctly identify object parameters (instead of defaulting to string)
    Test file (hitl.test.ts):
  • New test verifying object parameters are typed as 'object'

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Nov 24, 2025
@bbovenzi bbovenzi added this to the Airflow 3.1.4 milestone Nov 25, 2025
@bbovenzi bbovenzi added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Nov 25, 2025
@bbovenzi
Copy link
Contributor

Thanks for adding a test too!

@bbovenzi bbovenzi merged commit caab2a9 into apache:main Nov 25, 2025
62 checks passed
@github-actions
Copy link

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker caab2a9 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@stuart23
Copy link
Contributor Author

Thanks for adding a test too!

You know I always do! 😉

@stuart23 stuart23 deleted the stuart23-fix-hitl-object-rendering branch November 26, 2025 02:58
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Dec 1, 2025
ephraimbuddy pushed a commit that referenced this pull request Dec 2, 2025
ephraimbuddy pushed a commit that referenced this pull request Dec 3, 2025
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants