Fix race condition in test_execute_wildcard for LocalFilesystemToGCSOperator to fix CI #58613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
potiuk
added
the
backport-to-v3-1-test
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Nov 24, 2025
…systemToGCSOperator (apache#58613) (cherry picked from commit a4965b8) Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
Member
|
Backport in #58617 |
70 tasks
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The test was using a hardcoded
/tmp/fake*.csvpath instead of the unique temporary directory (self.tmpdir_posix) provided by pytest'stmp_pathfixture. When tests run in parallel with pytest-xdist, multiple test instances could see each other's files in the shared/tmp/directory, causing race conditions.Fix
Changed line to use
f"{self.tmpdir_posix}/fake*.csv"instead of the hardcoded/tmp/fake*.csv, ensuring each test instance only looks at files in its own isolated temporary directory.Fixes CI failure: https://github.com/apache/airflow/actions/runs/19626674515
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.