Skip to content

[v3-1-test] Use filelock to fix race condition in version suffix test for xdist runs (#58608) #58616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Nov 24, 2025
Merged

[v3-1-test] Use filelock to fix race condition in version suffix test for xdist runs (#58608) #58616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions dev/breeze/tests/test_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,22 +397,17 @@ def test_apply_version_suffix_to_provider_pyproject_toml(provider_id, version_su


@pytest.fixture
def restore_version_files():
# save contents of all version files before test starts
version_files = [
AIRFLOW_CORE_INIT_PY,
TASK_SDK_INIT_PY,
AIRFLOWCTL_INIT_PY,
]
original_contents = {f: f.read_text() for f in version_files if f.exists()}
def lock_version_files():
from filelock import FileLock

yield

# restore original contents after test
for fp, content in original_contents.items():
fp.write_text(content)
lock_file = AIRFLOW_ROOT_PATH / ".version_files.lock"
with FileLock(lock_file):
yield
if lock_file.exists():
lock_file.unlink()


@pytest.mark.usefixtures("lock_version_files")
@pytest.mark.parametrize(
("distributions", "init_file_path", "version_suffix", "floored_version_suffix"),
[
Expand Down Expand Up @@ -440,7 +435,6 @@ def restore_version_files():
],
)
def test_apply_version_suffix_to_non_provider_pyproject_tomls(
restore_version_files,
distributions: tuple[str, ...],
init_file_path: Path,
version_suffix: str,
Expand Down