-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Change task log source display to hidden by default #58749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change task log source display to hidden by default #58749
Conversation
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the change, but I'm not sure whether we should have this change since task log source seems like kind of important info. Would like to listen to another opinions!
The source line creates a lot of noise in the logs. Changing the default hides the noise unless someone wants to explicitly see the that information. This behavior is aligned with Airflow 2.x and I think having the source always on was unintentional in Airflow 3 |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I think it's fine. Indeed I find it harder to read from the start when source is there by default. People can activate it if needed. Also people used to that in the first place have the setting persisted in the localstorage, so this will not change anything. (unless they clear their cache). We can try like this and see what people think. (easy to revert otherwise) |
Update the default behavior for task log source display from shown to hidden, providing a cleaner initial view of logs. Users can still toggle source visibility using the settings menu
4c55692 to
59d9040
Compare
* Change task log source display to hidden by default Update the default behavior for task log source display from shown to hidden, providing a cleaner initial view of logs. Users can still toggle source visibility using the settings menu * Fix tests (cherry picked from commit d024a46) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
…) (#59045) * Change task log source display to hidden by default Update the default behavior for task log source display from shown to hidden, providing a cleaner initial view of logs. Users can still toggle source visibility using the settings menu * Fix tests (cherry picked from commit d024a46) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
* Change task log source display to hidden by default Update the default behavior for task log source display from shown to hidden, providing a cleaner initial view of logs. Users can still toggle source visibility using the settings menu * Fix tests
…) (#59045) * Change task log source display to hidden by default Update the default behavior for task log source display from shown to hidden, providing a cleaner initial view of logs. Users can still toggle source visibility using the settings menu * Fix tests (cherry picked from commit d024a46) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
…) (#59045) * Change task log source display to hidden by default Update the default behavior for task log source display from shown to hidden, providing a cleaner initial view of logs. Users can still toggle source visibility using the settings menu * Fix tests (cherry picked from commit d024a46) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
…) (#59045) * Change task log source display to hidden by default Update the default behavior for task log source display from shown to hidden, providing a cleaner initial view of logs. Users can still toggle source visibility using the settings menu * Fix tests (cherry picked from commit d024a46) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
…) (#59045) * Change task log source display to hidden by default Update the default behavior for task log source display from shown to hidden, providing a cleaner initial view of logs. Users can still toggle source visibility using the settings menu * Fix tests (cherry picked from commit d024a46) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
…) (#59045) * Change task log source display to hidden by default Update the default behavior for task log source display from shown to hidden, providing a cleaner initial view of logs. Users can still toggle source visibility using the settings menu * Fix tests (cherry picked from commit d024a46) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
…) (#59045) * Change task log source display to hidden by default Update the default behavior for task log source display from shown to hidden, providing a cleaner initial view of logs. Users can still toggle source visibility using the settings menu * Fix tests (cherry picked from commit d024a46) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
…) (#59045) * Change task log source display to hidden by default Update the default behavior for task log source display from shown to hidden, providing a cleaner initial view of logs. Users can still toggle source visibility using the settings menu * Fix tests (cherry picked from commit d024a46) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
…) (#59045) * Change task log source display to hidden by default Update the default behavior for task log source display from shown to hidden, providing a cleaner initial view of logs. Users can still toggle source visibility using the settings menu * Fix tests (cherry picked from commit d024a46) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
…) (#59045) * Change task log source display to hidden by default Update the default behavior for task log source display from shown to hidden, providing a cleaner initial view of logs. Users can still toggle source visibility using the settings menu * Fix tests (cherry picked from commit d024a46) Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
Update the default behavior for task log source display from shown
to hidden, providing a cleaner initial view of logs. Users can still
toggle source visibility using the settings menu