Skip to content

Conversation

@nikhilnadig28
Copy link
Contributor

@nikhilnadig28 nikhilnadig28 commented Nov 27, 2025

Fixes: #58764
Adds enable_open_telemetry_tracing parameter to PubSubHook and PubSubPublishMessageOperator, allowing users to enable native OpenTelemetry tracing for Pub/Sub messages via the google-cloud-pubsub client library. The hook already passes PublisherOptions for message ordering; this extends it to support tracing.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Nov 27, 2025
@nikhilnadig28
Copy link
Contributor Author

nikhilnadig28 commented Nov 27, 2025

The CI is failing on the lowest-direct-dependencies test because enable_open_telemetry_tracing was added to PublisherOptions in google-cloud-pubsub v2.24.0, but the current minimum version in pyproject.toml is >=2.21.3.

Should I push this dependency version bump as part of this PR, or would you prefer a separate PR for the version update?

Edit: Decided to push the change here. Happy to take feedback on this :)

@nikhilnadig28
Copy link
Contributor Author

CI is green. This PR is ready for review. Would appreciate feedback from anyone familiar with the Google provider

@potiuk
Copy link
Member

potiuk commented Dec 1, 2025

Edit: Decided to push the change here. Happy to take feedback on this :)

Good choice.

@potiuk potiuk merged commit 9ad9926 into apache:main Dec 1, 2025
94 checks passed
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Dec 3, 2025
…SubPublishMessageOperator (apache#58766)

* feat(google): add enable_open_telemetry_tracing to PubSubHook and PubSubPublishMessageOperator

* chore(google): bump google-cloud-pubsub minimum to 2.24.0 for otel support
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
…SubPublishMessageOperator (apache#58766)

* feat(google): add enable_open_telemetry_tracing to PubSubHook and PubSubPublishMessageOperator

* chore(google): bump google-cloud-pubsub minimum to 2.24.0 for otel support
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
…SubPublishMessageOperator (apache#58766)

* feat(google): add enable_open_telemetry_tracing to PubSubHook and PubSubPublishMessageOperator

* chore(google): bump google-cloud-pubsub minimum to 2.24.0 for otel support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add publisher_options support to PubSubHook for OpenTelemetry tracing

2 participants