Skip to content

Conversation

@anshuksi282-ksolves
Copy link
Contributor

@anshuksi282-ksolves anshuksi282-ksolves commented Nov 28, 2025

Fix: Responsive layout issue in Historical Metrics (Asset Events box)

This PR fixes a UI responsiveness issue reported in #58133, where the Asset Events section inside Historical Metrics was overflowing and misaligned on smaller screens.

What was happening

  • The Asset Events card was not respecting grid boundaries.
  • On smaller screens, it was shifting downward and appearing outside the main grid.
  • The sort dropdown (Newest First) was also overflowing the parent container.

What this PR changes

  • Adds responsive Chakra UI props to ensure proper wrapping inside the SimpleGrid.
  • Prevents the AssetEvents box from overflowing horizontally.
  • Ensures both the Dag Run Metrics and Asset Events sections stack properly on mobile.
  • Maintains minimal and clean changes without affecting other UI components.

Before (Broken)

  • Asset Events box overflowing outside container
  • Sort dropdown escaping layout
Screenshot from 2025-11-28 16-26-15

After (Fixed)

  • Fully responsive
  • Boxes stack correctly on small screens
  • No overflow; consistent spacing
Screencast.from.2025-11-28.13-29-02.webm

Notes

  • Pure UI fix; no backend or functional logic changed.
  • Does not introduce any breaking changes.
  • No new dependencies added.

related: #58133


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Nov 28, 2025
Copy link
Member

@choo121600 choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of shortening the pool’s length,
I think placing it on the line below the health section would work better.

@anshuksi282-ksolves
Copy link
Contributor Author

anshuksi282-ksolves commented Nov 28, 2025

Instead of shortening the pool’s length, I think placing it on the line below the health section would work better.

Hi @choo121600, Thanks for the review! Updated the layout as suggested — pool summary now moves below Health section on smaller screens. Let me know if anything else is needed

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@pierrejeambrun pierrejeambrun added this to the Airflow 3.1.4 milestone Nov 28, 2025
@pierrejeambrun pierrejeambrun added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Nov 28, 2025
@guan404ming guan404ming merged commit f103218 into apache:main Nov 29, 2025
60 checks passed
@guan404ming
Copy link
Member

Looks nice, thanks!

github-actions bot pushed a commit that referenced this pull request Nov 29, 2025
…ons (#58811)

* fix(UI):Improve mobile responsiveness of Dashboard sections

* Address reviewer comments: improve responsiveness layout
(cherry picked from commit f103218)

Co-authored-by: Anshu Singh <anshu.singh@ksolves.com>
@github-actions
Copy link

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Nov 29, 2025
…ons (apache#58811)

* fix(UI):Improve mobile responsiveness of Dashboard sections

* Address reviewer comments: improve responsiveness layout
(cherry picked from commit f103218)

Co-authored-by: Anshu Singh <anshu.singh@ksolves.com>
jscheffl pushed a commit that referenced this pull request Nov 29, 2025
…ons (#58811) (#58853)

* fix(UI):Improve mobile responsiveness of Dashboard sections

* Address reviewer comments: improve responsiveness layout
(cherry picked from commit f103218)

Co-authored-by: Anshu Singh <anshu.singh@ksolves.com>
ephraimbuddy pushed a commit that referenced this pull request Dec 3, 2025
…ons (#58811) (#58853)

* fix(UI):Improve mobile responsiveness of Dashboard sections

* Address reviewer comments: improve responsiveness layout
(cherry picked from commit f103218)

Co-authored-by: Anshu Singh <anshu.singh@ksolves.com>
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Dec 3, 2025
…58811)

* fix(UI):Improve mobile responsiveness of Dashboard sections

* Address reviewer comments: improve responsiveness layout
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
…58811)

* fix(UI):Improve mobile responsiveness of Dashboard sections

* Address reviewer comments: improve responsiveness layout
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
…58811)

* fix(UI):Improve mobile responsiveness of Dashboard sections

* Address reviewer comments: improve responsiveness layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants