[v3-1-test] Fix incorrect backfill duration calculation in Grid view (#58813) #58816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…58813) The duration was calculated using timedelta.seconds which, returns only the seconds component, not the total duration. This caused backfills lasting more than a day to show incorrect durations. Changed to use total_seconds() which correctly returns the full duration. (cherry picked from commit acfcba1) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
boring-cyborg
bot
added
area:API
pierrejeambrun
requested review from
bbovenzi,
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
pierrejeambrun,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
pierrejeambrun
approved these changes
Nov 28, 2025
ephraimbuddy
added a commit
that referenced
this pull request
Dec 3, 2025
…58813) (#58816) The duration was calculated using timedelta.seconds which, returns only the seconds component, not the total duration. This caused backfills lasting more than a day to show incorrect durations. Changed to use total_seconds() which correctly returns the full duration. (cherry picked from commit acfcba1) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duration was calculated using timedelta.seconds which,
returns only the seconds component, not the total duration.
This caused backfills lasting more than a day to show incorrect durations.
Changed to use total_seconds() which correctly returns the full duration.
(cherry picked from commit acfcba1)
Co-authored-by: Ephraim Anierobi splendidzigy24@gmail.com