Skip to content

Conversation

@vincbeck
Copy link
Contributor

I ran the PMC checks for provider release for the first time and I found some two very minor glimpses in the doc.

  • breeze release-management check-release-files providers requires the --path-to-airflow-svn parameter
  • The parameter --packages-file should contain the reference to the packages.txt file from the Airflow root repo and not the current directory.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you follow it exactly, those arguments are set from recently set variables. But yes - it does not hurt to pass them explicitly.

@potiuk
Copy link
Member

potiuk commented Nov 28, 2025

especially - worth spelling out the --package-file which otherwise requires this package to be in cwd (so you have to do cd dev before

@vincbeck
Copy link
Contributor Author

If you follow it exactly, those arguments are set from recently set variables. But yes - it does not hurt to pass them explicitly.

Interesting, I might have missed something then

@vincbeck
Copy link
Contributor Author

especially - worth spelling out the --package-file which otherwise requires this package to be in cwd (so you have to do cd dev before

That's the thing, I was in dev directory and could not find the file. When provided --packages-file dev/packages.txt it worked (still inside dev directory)

@vincbeck vincbeck force-pushed the vincbeck/provider_release_pmc_doc branch from 9a50282 to 5d685a2 Compare November 28, 2025 21:18
@jscheffl
Copy link
Contributor

Static checks are fixed in #58835, failure can be ignored.

@vincbeck vincbeck merged commit 1f4f28d into apache:main Nov 28, 2025
60 of 61 checks passed
@vincbeck vincbeck deleted the vincbeck/provider_release_pmc_doc branch November 28, 2025 22:16
github-actions bot pushed a commit that referenced this pull request Nov 28, 2025
(cherry picked from commit 1f4f28d)

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
@github-actions
Copy link

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

@jscheffl
Copy link
Contributor

Providers are released from main, no backport needed in my view.

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Nov 28, 2025
(cherry picked from commit 1f4f28d)

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Dec 3, 2025
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants