Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Nov 29, 2025

When common.compat changes, but the providers that use it, do not have # use next version added for the common-compat dependency, the PR should fail.

You can still bypass the check with the label set on the PR:

'skip common compat check'


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Nov 29, 2025

This is an error that will be printed on PR when common.compat changes and other providers are changing in the same PR but there is no # use next version added;

Screenshot 2025-11-29 at 01 06 13

You can test it with breeze ci selective-check --commit-ref c52606a7a7465f5900f16bb8719c6d378c320df5

@potiuk
Copy link
Member Author

potiuk commented Nov 29, 2025

cc: @ephraimbuddy :) -> this way in the future, the one who modifies common.compat will not be able to merge their PR until # use next version is added.

@potiuk potiuk force-pushed the add-common-compat-check branch from da2d7dd to 90e24d7 Compare November 29, 2025 00:44
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of AI generated code that is very verbose. Sometimes I think the AI bot is paid by LoC generated and not by making it conceise.

@potiuk potiuk force-pushed the add-common-compat-check branch from 90e24d7 to ae8b0d5 Compare November 29, 2025 11:11
@potiuk
Copy link
Member Author

potiuk commented Nov 29, 2025

A lot of AI generated code that is very verbose. Sometimes I think the AI bot is paid by LoC generated and not by making it conceise.

Yeah. I did it late in night and after waking up, it was a bit too verbose. I asked Claude Sonnet to simplify and it not only did all the changes you suggested but also nicely refactored it into separate private methods which IMHO makes it far easier to comprehend and understand what we are doing

@potiuk potiuk force-pushed the add-common-compat-check branch from ae8b0d5 to 967389a Compare November 29, 2025 11:16
When common.compat changes, but the providers that use it, do not
have `# use next version` added for the common-compat dependency,
the PR should fail.

You can still bypass the check with the label set on the PR:

'skip common compat check'
@potiuk potiuk force-pushed the add-common-compat-check branch from 967389a to f1235e6 Compare November 29, 2025 11:20
@potiuk
Copy link
Member Author

potiuk commented Nov 29, 2025

A lot of AI generated code that is very verbose. Sometimes I think the AI bot is paid by LoC generated and not by making it conceise.

Not in this case, but in a way that might be a good thing. More verbose code is quite often easier to understand - even if longer to read. Sometimes the comprehensions take quite a bit of mental effort to understand where simple for loop is clear and straightforrward. I think human authors (comparing to AI) over-optimise for "writing" rather than "reading" - and writing concise and short code is preferred by some people, but it only works to a point.

But yes. This one was definitely too chatty.

@potiuk potiuk merged commit 65aec2d into apache:main Nov 29, 2025
118 checks passed
@potiuk potiuk deleted the add-common-compat-check branch November 29, 2025 12:59
@github-actions
Copy link

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 65aec2d v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Dec 3, 2025
…apache#58840)

When common.compat changes, but the providers that use it, do not
have `# use next version` added for the common-compat dependency,
the PR should fail.

You can still bypass the check with the label set on the PR:

'skip common compat check'
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
…apache#58840)

When common.compat changes, but the providers that use it, do not
have `# use next version` added for the common-compat dependency,
the PR should fail.

You can still bypass the check with the label set on the PR:

'skip common compat check'
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
…apache#58840)

When common.compat changes, but the providers that use it, do not
have `# use next version` added for the common-compat dependency,
the PR should fail.

You can still bypass the check with the label set on the PR:

'skip common compat check'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants