Snowflake: Support optional scope in OAuth token request #58871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
boring-cyborg
bot
added
area:providers
kind:documentation
provider:snowflake
2 tasks
SameerMesiah97
force-pushed
the
58815-Snowflake-Oauth-Scope
branch
from
a5e617d to
47fcbea
Compare
Omit scope field when unset instead of defaulting to None, and add tests for scoped and unscoped OAuth requests Fix SnowflakeHook OAuth tests to correctly handle client_credentials flow Docs: Add ``scope`` parameter description for OAuth in SnowflakeHook Fixed tests to ensure client_credentials code path is tested instead of refresh token Fixed formatting issues and removed extraneous comments
SameerMesiah97
force-pushed
the
58815-Snowflake-Oauth-Scope
branch
from
47fcbea to
2e8366a
Compare
Contributor
|
i think there is another pr for the same thing? #58863 |
Contributor
Author
Please see my comment on the existing issue. |
potiuk
approved these changes
Dec 1, 2025
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Dec 3, 2025
Omit scope field when unset instead of defaulting to None, and add tests for scoped and unscoped OAuth requests Fix SnowflakeHook OAuth tests to correctly handle client_credentials flow Docs: Add ``scope`` parameter description for OAuth in SnowflakeHook Fixed tests to ensure client_credentials code path is tested instead of refresh token Fixed formatting issues and removed extraneous comments Co-authored-by: Sameer Mesiah <smesiah971@gmail.com>
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
Omit scope field when unset instead of defaulting to None, and add tests for scoped and unscoped OAuth requests Fix SnowflakeHook OAuth tests to correctly handle client_credentials flow Docs: Add ``scope`` parameter description for OAuth in SnowflakeHook Fixed tests to ensure client_credentials code path is tested instead of refresh token Fixed formatting issues and removed extraneous comments Co-authored-by: Sameer Mesiah <smesiah971@gmail.com>
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
Omit scope field when unset instead of defaulting to None, and add tests for scoped and unscoped OAuth requests Fix SnowflakeHook OAuth tests to correctly handle client_credentials flow Docs: Add ``scope`` parameter description for OAuth in SnowflakeHook Fixed tests to ensure client_credentials code path is tested instead of refresh token Fixed formatting issues and removed extraneous comments Co-authored-by: Sameer Mesiah <smesiah971@gmail.com>
52 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the OAuth
scopeparameter in theSnowflakeHookand adds the associated OAuth tests to correctly validate both scoped and unscoped token requests. Previously, the scope value was not included in the Snowflake OAuth token request.Details
Ensures consistent handling of the scope parameter across all OAuth grant types. Adds test that reflect the real execution path.
Notes
Although the original issue focused on adding scope support for the
client_credentialsgrant type, scope can also be optionally included when using therefresh_tokenOAuth flow. This PR provides a general implementation that supports both.Closes: #58815