Skip to content

Fix mypy errors in sql_to_s3 due to pandas stub bump #58923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Dec 2, 2025
Merged

Fix mypy errors in sql_to_s3 due to pandas stub bump #58923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions providers/amazon/src/airflow/providers/amazon/aws/transfers/sql_to_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def _fix_dtypes(df: pd.DataFrame, file_format: FILE_FORMAT) -> None:
if df[col].dtype.name == "object" and file_format == FILE_FORMAT.PARQUET:
# if the type wasn't identified or converted, change it to a string so if can still be
# processed.
df[col] = df[col].astype(str)
df[col] = cast("pd.Series", df[col].astype(str))

if "float" in df[col].dtype.name and df[col].hasnans:
# inspect values to determine if dtype of non-null values is int or float
Expand All @@ -201,13 +201,13 @@ def _fix_dtypes(df: pd.DataFrame, file_format: FILE_FORMAT) -> None:
# The type ignore can be removed here if https://github.com/numpy/numpy/pull/23690
# is merged and released as currently NumPy does not consider None as valid for x/y.
df[col] = np.where(df[col].isnull(), None, df[col]) # type: ignore[call-overload]
df[col] = df[col].astype(pd.Int64Dtype())
df[col] = cast("pd.Series", df[col].astype(pd.Int64Dtype()))
elif np.isclose(notna_series, notna_series.astype(int)).all():
# set to float dtype that retains floats and supports NaNs
# The type ignore can be removed here if https://github.com/numpy/numpy/pull/23690
# is merged and released
df[col] = np.where(df[col].isnull(), None, df[col]) # type: ignore[call-overload]
df[col] = df[col].astype(pd.Float64Dtype())
df[col] = cast("pd.Series", df[col].astype(pd.Float64Dtype()))

@staticmethod
def _strip_suffixes(
Expand Down