fix(sftp): add default port to SFTPHookAsync #58945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
force-pushed
the
sftp-async-hook-port-fallback
branch
2 times, most recently
from
3ca4be8 to
5c5efd9
Compare
Lee-W
force-pushed
the
sftp-async-hook-port-fallback
branch
from
5c5efd9 to
b26fbb0
Compare
jason810496
approved these changes
Dec 4, 2025
guan404ming
approved these changes
Dec 4, 2025
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
52 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If the port is not set in Airflow UI for
SFTPHookAsync, it will not default to port 22, which is inconsistent withSFTPHook. During debugging, I also found out lots of arguments are ignored inSFTPHookAsyncWhat
Fallback to port 22 if not set and use the arguments passed through
SFTPHookAsyn.__init__.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.